This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Communicate switch status to semantics on Windows #36177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
requested review from
a-wallen,
cbracken,
chunhtai and
loic-sharma
chunhtai
reviewed
Sep 15, 2022
| varchild.lVal = CHILDID_SELF; | ||
| VARIANT native_state = {}; | ||
| ASSERT_TRUE(SUCCEEDED(native_view->get_accState(varchild, &native_state))); | ||
| EXPECT_FALSE(native_state.lVal & STATE_SYSTEM_PRESSED); |
Contributor
There was a problem hiding this comment.
Is it possible to also test its MSAARole is ROLE_SYSTEM_CHECKBUTTON?
|
|
||
| case ax::mojom::Role::kToggleButton: | ||
| return ROLE_SYSTEM_PUSHBUTTON; | ||
| return ROLE_SYSTEM_CHECKBUTTON; |
Contributor
There was a problem hiding this comment.
Is check button basically a check box? Why do we choose this over push button?
Contributor
Author
There was a problem hiding this comment.
It is the same role as for a checkbox. In #flutter/fluter/111525 we are currently of the opinion that it is the most appropriate role, as it is for interactable widgets with toggleable state, and the materials design guidelines recommend their use in place of checkboxes on mobile
Contributor
There was a problem hiding this comment.
thanks for explanation. SGTM
chunhtai
approved these changes
Sep 15, 2022
|
|
||
| case ax::mojom::Role::kToggleButton: | ||
| return ROLE_SYSTEM_PUSHBUTTON; | ||
| return ROLE_SYSTEM_CHECKBUTTON; |
Contributor
There was a problem hiding this comment.
thanks for explanation. SGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
* Switch semantics * Test native role
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch widgets used to have the
PUSHBUTTONrole on Windows, which has no associated state. This PR switches it to aCHECKBUTTONand associates thePRESSEDstate with its MSAA node when it is toggled. Adds a unit test to verify that the native state reflects the toggle state of the Switch.Also fixes some typos in comments in the existing checkbox unit test.
Addresses #flutter/flutter/111525
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.