Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented Oct 5, 2022

This is another step towards removing the special sauce from solid stroke rendering. See also: https://flutter.dev/go/impeller-geometry#heading=h.fymtgh4bhdl2

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@chinmaygarde chinmaygarde changed the title Switch SolidStrokeContents to use solid fill shaders; remove solid stroke shaders [Impeller] Switch SolidStrokeContents to use solid fill shaders; remove solid stroke shaders Oct 6, 2022
@jonahwilliams
Copy link
Contributor

I don't know if these tasks are going to finish . If you push an empty commit, that should unclog it...

@bdero bdero force-pushed the bdero/remove-solid-stroke-shaders branch from dbe13cb to df956fa Compare October 8, 2022 03:04
@bdero
Copy link
Member Author

bdero commented Oct 8, 2022

Whoops, thanks. This fell off my radar.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 8, 2022

auto label is removed for flutter/engine, pr: 36624, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bdero bdero force-pushed the bdero/remove-solid-stroke-shaders branch from df956fa to f8cfd6f Compare October 8, 2022 04:14
@bdero bdero merged commit 823f0a9 into flutter:main Oct 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants