Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Correct the ordering of filters in 'Paint::WithFilters' #37239

Merged
auto-submit merged 1 commit into from
Nov 3, 2022
Merged

[Impeller] Correct the ordering of filters in 'Paint::WithFilters' #37239

auto-submit merged 1 commit into from
Nov 3, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Nov 2, 2022 •
edited
Loading

It seems to apply the color filter first, and then apply the image filter.

See this example for details
https://fiddle.skia.org/c/5e62809886613c144f50fa99f1954850

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ColdPaleLight ColdPaleLight requested a review from bdero November 2, 2022 10:53
@ColdPaleLight ColdPaleLight self-assigned this Nov 2, 2022
@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2022
@auto-submit auto-submit bot merged commit 7843ae8 into flutter:main Nov 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
78d7996 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
4221526 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
d525b03 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
0c01b59 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
f2bf3fd 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
e2be22a 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
7ccd41e 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
57eb835 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
7e25e5f 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
34d0443 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
0a6676c 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
1eac87e 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
7f0fc2d 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
9985f49 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
7c1f442 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
6d95f3c 
…ters' (flutter/engine#37239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFil…
538f366 
…ters' (flutter/engine#37239)
GaryQian pushed a commit to flutter/flutter that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 840a7b3 to 66b244d (25 revisions) (#114640)
44ecbbc 
* 27972e7 [fuchsia] mouse-input test (flutter/engine#37221)

* 491032c Update docs to mention felt build --host (flutter/engine#37224)

* 5108942 [macOS, multiwindow] Compositor gets FlutterView lazily (flutter/engine#36392)

* 2e89bce Enter a scope before calling Dart APIs in ThrowIfUIOperationsProhibited (flutter/engine#37226)

* 7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFilters' (flutter/engine#37239)

* 2cbe38b Produce both ddc and dart2js platform files. (flutter/engine#37162)

* 2e3bc80 Apply internal cl for C++20 prep (flutter/engine#37266)

* c183e77 Roll Dart SDK from 883ab3f70e3d to 94ac8f6cc756 (1 revision) (flutter/engine#37267)

* d21f346 Roll Fuchsia Mac SDK from BPxzJkBzD8R9GFg1n... to 8OZH-l7aK1-73Hyrf... (flutter/engine#37270)

* edbba91 Roll Fuchsia Linux SDK from 9P-WnaDSnineZtFz0... to np4MU3wmDOuhlg6CR... (flutter/engine#37269)

* c7b2230 [Impeller] Wire-up AndroidSurfaceImpellerVulkan (flutter/engine#37249)

* 73c5881 [Impeller] dont call SPIRV_CROSS_THROW in SkSL backend (flutter/engine#37273)

* 893f5cd Roll Skia from f41fa8bffd58 to 78927395bf5c (20 revisions) (flutter/engine#37275)

* 2a7f3d0 Roll Skia from 78927395bf5c to fe751b616832 (1 revision) (flutter/engine#37276)

* fbe98c0 Roll Dart SDK from 94ac8f6cc756 to 8e089c61be58 (2 revisions) (flutter/engine#37277)

* 95b9b5d [Impeller] Add blit command to copy texture to buffer (flutter/engine#37198)

* 50c0fbc Roll Dart SDK from 8e089c61be58 to 866f5cfad18a (1 revision) (flutter/engine#37278)

* 138aceb Roll Skia from fe751b616832 to fdfa00287cff (1 revision) (flutter/engine#37279)

* 224b401 Roll Fuchsia Mac SDK from 8OZH-l7aK1-73Hyrf... to mOXbRSWGSdWRXIefR... (flutter/engine#37282)

* 74f0219 Announce alerts through SemanticsService on Windows (flutter/engine#37173)

* a828fbb Roll Dart SDK from 866f5cfad18a to 433f075a852b (1 revision) (flutter/engine#37284)

* 49165f1 Roll Fuchsia Linux SDK from np4MU3wmDOuhlg6CR... to -0Xq1c-TncmWBWzqg... (flutter/engine#37285)

* d06616e Roll Skia from fdfa00287cff to cf3fa752a958 (2 revisions) (flutter/engine#37288)

* 0b79b5c Roll Skia from cf3fa752a958 to af0582c7b223 (5 revisions) (flutter/engine#37290)

* 66b244d [Impeller] validate calls to texture in SkSL (flutter/engine#37289)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@ColdPaleLight @schwa423
[Impeller] Correct the ordering of filters in 'Paint::WithFilters' (f…
7af3ba9 
…lutter#37239)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 840a7b3 to 66b244d (25 revisions) (flutter#1…
1381740 
…14640)

* 27972e7 [fuchsia] mouse-input test (flutter/engine#37221)

* 491032c Update docs to mention felt build --host (flutter/engine#37224)

* 5108942 [macOS, multiwindow] Compositor gets FlutterView lazily (flutter/engine#36392)

* 2e89bce Enter a scope before calling Dart APIs in ThrowIfUIOperationsProhibited (flutter/engine#37226)

* 7843ae8 [Impeller] Correct the ordering of filters in 'Paint::WithFilters' (flutter/engine#37239)

* 2cbe38b Produce both ddc and dart2js platform files. (flutter/engine#37162)

* 2e3bc80 Apply internal cl for C++20 prep (flutter/engine#37266)

* c183e77 Roll Dart SDK from 883ab3f70e3d to 94ac8f6cc756 (1 revision) (flutter/engine#37267)

* d21f346 Roll Fuchsia Mac SDK from BPxzJkBzD8R9GFg1n... to 8OZH-l7aK1-73Hyrf... (flutter/engine#37270)

* edbba91 Roll Fuchsia Linux SDK from 9P-WnaDSnineZtFz0... to np4MU3wmDOuhlg6CR... (flutter/engine#37269)

* c7b2230 [Impeller] Wire-up AndroidSurfaceImpellerVulkan (flutter/engine#37249)

* 73c5881 [Impeller] dont call SPIRV_CROSS_THROW in SkSL backend (flutter/engine#37273)

* 893f5cd Roll Skia from f41fa8bffd58 to 78927395bf5c (20 revisions) (flutter/engine#37275)

* 2a7f3d0 Roll Skia from 78927395bf5c to fe751b616832 (1 revision) (flutter/engine#37276)

* fbe98c0 Roll Dart SDK from 94ac8f6cc756 to 8e089c61be58 (2 revisions) (flutter/engine#37277)

* 95b9b5d [Impeller] Add blit command to copy texture to buffer (flutter/engine#37198)

* 50c0fbc Roll Dart SDK from 8e089c61be58 to 866f5cfad18a (1 revision) (flutter/engine#37278)

* 138aceb Roll Skia from fe751b616832 to fdfa00287cff (1 revision) (flutter/engine#37279)

* 224b401 Roll Fuchsia Mac SDK from 8OZH-l7aK1-73Hyrf... to mOXbRSWGSdWRXIefR... (flutter/engine#37282)

* 74f0219 Announce alerts through SemanticsService on Windows (flutter/engine#37173)

* a828fbb Roll Dart SDK from 866f5cfad18a to 433f075a852b (1 revision) (flutter/engine#37284)

* 49165f1 Roll Fuchsia Linux SDK from np4MU3wmDOuhlg6CR... to -0Xq1c-TncmWBWzqg... (flutter/engine#37285)

* d06616e Roll Skia from fdfa00287cff to cf3fa752a958 (2 revisions) (flutter/engine#37288)

* 0b79b5c Roll Skia from cf3fa752a958 to af0582c7b223 (5 revisions) (flutter/engine#37290)

* 66b244d [Impeller] validate calls to texture in SkSL (flutter/engine#37289)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdero bdero Awaiting requested review from bdero

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ColdPaleLight ColdPaleLight

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ColdPaleLight @chinmaygarde