[fuchsia] Rename params and add comments to FlatlandConnection #40941
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| // This method is called from the UI thread. | ||
| void FlatlandConnection::AwaitVsync(FireCallbackCallback callback) { | ||
| const fml::TimePoint now = fml::TimePoint::Now(); |
There was a problem hiding this comment.
Could you add a comment explaining why you moved this here?
Since it's outside of the mutex, we could wait for some time inside of the mutex lock before executing the code below. At that point the "now" variable wouldnt be "now" anymore - it would represent some time in the past.
Was that your intention here?
arbreng
left a comment
arbreng
left a comment
There was a problem hiding this comment.
LGTM after either explaining the moved "now" variable or moving it back
This CL renames params and adds comments to FlatlandConnection to clarify behavior. Bug: fxb/123838
uysalere
force-pushed
the
comments-to-flatland-connection
branch
from
671daaf to
cc1fd6b
Compare
2 participants
This CL renames params and adds comments to FlatlandConnection to clarify behavior.
Bug: fxb/123838