Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -622,13 +622,22 @@ def ensure_ios_tests_are_built(ios_out_dir):
message.append(
'gn --ios --unoptimized --runtime-mode=debug --no-lto --simulator'
)
message.append('autoninja -C %s ios_test_flutter' % ios_out_dir)
message.append('ninja -C %s ios_test_flutter' % ios_out_dir)
final_message = "%s or %s doesn't exist. Please run the following commands: \n%s" % (
ios_out_dir, ios_test_lib, '\n'.join(message)
)
assert os.path.exists(tmp_out_dir
) and os.path.exists(ios_test_lib), final_message

ios_test_lib_time = os.path.getmtime(ios_test_lib)
flutter_dylib = os.path.join(tmp_out_dir, 'libFlutter.dylib')
flutter_dylib_time = os.path.getmtime(flutter_dylib)

final_message = '%s is older than %s. Please run the following commands: \n%s' % (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoninja is deprecated. Could you also change line 625 to be 'ninja -C ...' instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ios_test_lib, flutter_dylib, '\n'.join(message)
)
assert flutter_dylib_time <= ios_test_lib_time, final_message


def assert_expected_xcode_version():
"""Checks that the user has a version of Xcode installed"""
Expand Down