This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller][WIP] increase initial size of alpha bitmap atlas texture. #41781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
jonahwilliams
commented
May 6, 2023
Comment on lines
+826
to
+827
| std::shared_ptr<GlyphAtlasContext> alpha_glyph_atlas_context_; | ||
| std::shared_ptr<GlyphAtlasContext> color_glyph_atlas_context_; |
Contributor
Author
There was a problem hiding this comment.
I could put these into a map or something else. Feels weird to make a second container but might as well. I don't think we'll end up with a third glyph atlas, at least not for a while
Contributor
Author
|
Closing in favor of #41880 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#126103
Requires #41780
Unlike Skia which starts with 2048x2048, I decreased the size of 1024x1024. Now that we'll never switch this to a color bitmap, the memory impact is dramatically lessened.