[Impeller] starts running vulkan golden image tests with swiftshader #41958

gaaclarke · 2023-05-11T20:51:44Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2023-05-11T22:54:42Z

impeller/golden_tests/golden_playground_test_mac.cc

    : pimpl_(new GoldenPlaygroundTest::GoldenPlaygroundTestImpl()) {}

+void GoldenPlaygroundTest::TearDown() {
+  ASSERT_FALSE(dlopen("/usr/local/lib/libMoltenVK.dylib", RTLD_NOLOAD));


I added this to make sure we don't accidentally swap out the backend.

gaaclarke · 2023-05-11T22:55:50Z

testing/run_tests.py

        'impeller_unittests',
        executable_filter,
-        shuffle_flags,
+        ['--gtest_filter=-*/Vulkan'] + shuffle_flags,


Now that the bot is building with vulkan enabled we need to turn these tests off. I tried to run them with swiftshader and it didn't work. I didn't look into it closely, opting to turn them off instead. It doesn't seem worthwhile to make this a flag.

flutter-dashboard · 2023-05-11T23:26:59Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41958 at sha 8211786

bdero

LGTM!

…tshader (flutter/engine#41958)

flutter/engine@c784d6d...502e1eb 2023-05-12 30870216+gaaclarke@users.noreply.github.com [Impeller] starts running vulkan golden image tests with swiftshader (flutter/engine#41958) 2023-05-12 mdebbar@google.com [web] Fix crash on old versions of Chrome (Intl.Segmenter missing) (flutter/engine#41986) 2023-05-12 godofredoc@google.com Move clang tidy v2 build to prod. (flutter/engine#41985) 2023-05-12 godofredoc@google.com Reland "Move linux_license to engine v2."" (flutter/engine#41983) 2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 6cd6e54f280d to 858f83d6d993 (2 revisions) (flutter/engine#41980) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 0b929ada9cc6 to 539fb10d7cfb (2 revisions) (flutter/engine#41979) 2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... (flutter/engine#41975) 2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 4028c7d8b87c to 6cd6e54f280d (1 revision) (flutter/engine#41974) 2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... (flutter/engine#41973) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 208a07f71701 to 0b929ada9cc6 (2 revisions) (flutter/engine#41971) 2023-05-12 dnfield@google.com [Impeller] [Android] Refactor the Android context/surface implementation to work more like Skia. (flutter/engine#41059) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from ccec5093ca38 to 208a07f71701 (1 revision) (flutter/engine#41970) 2023-05-12 jonahwilliams@google.com [Impeller] Dont synthesize fake index buffer if none was provided to VBB (flutter/engine#41969) 2023-05-12 dnfield@google.com [Impeller] Make index buffer optional (flutter/engine#41962) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lf8VcONMWlne to HMLNsG7w9sTD fuchsia/sdk/core/mac-amd64 from MjcKzcsqMDku to rO5qs4MpN6Wf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…26714) flutter/engine@c784d6d...502e1eb 2023-05-12 30870216+gaaclarke@users.noreply.github.com [Impeller] starts running vulkan golden image tests with swiftshader (flutter/engine#41958) 2023-05-12 mdebbar@google.com [web] Fix crash on old versions of Chrome (Intl.Segmenter missing) (flutter/engine#41986) 2023-05-12 godofredoc@google.com Move clang tidy v2 build to prod. (flutter/engine#41985) 2023-05-12 godofredoc@google.com Reland "Move linux_license to engine v2."" (flutter/engine#41983) 2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 6cd6e54f280d to 858f83d6d993 (2 revisions) (flutter/engine#41980) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 0b929ada9cc6 to 539fb10d7cfb (2 revisions) (flutter/engine#41979) 2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... (flutter/engine#41975) 2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 4028c7d8b87c to 6cd6e54f280d (1 revision) (flutter/engine#41974) 2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... (flutter/engine#41973) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 208a07f71701 to 0b929ada9cc6 (2 revisions) (flutter/engine#41971) 2023-05-12 dnfield@google.com [Impeller] [Android] Refactor the Android context/surface implementation to work more like Skia. (flutter/engine#41059) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from ccec5093ca38 to 208a07f71701 (1 revision) (flutter/engine#41970) 2023-05-12 jonahwilliams@google.com [Impeller] Dont synthesize fake index buffer if none was provided to VBB (flutter/engine#41969) 2023-05-12 dnfield@google.com [Impeller] Make index buffer optional (flutter/engine#41962) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lf8VcONMWlne to HMLNsG7w9sTD fuchsia/sdk/core/mac-amd64 from MjcKzcsqMDku to rO5qs4MpN6Wf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

gaaclarke force-pushed the vulkan-swiftshader branch 2 times, most recently from 49daef8 to caccef8 Compare May 11, 2023 20:53

gaaclarke added 4 commits May 11, 2023 15:42

[Impeller] Turned on swiftshader for golden image tests

7396ab4

started compiling with vulkan enabled

b82ada0

made impeller_unittests use swiftshader on mac

1fc6fc6

turned off vulkan tests for mac

8211786

gaaclarke force-pushed the vulkan-swiftshader branch from 57b3558 to 8211786 Compare May 11, 2023 22:42

gaaclarke commented May 11, 2023

View reviewed changes

gaaclarke marked this pull request as ready for review May 11, 2023 23:03

gaaclarke requested a review from bdero May 11, 2023 23:03

flutter-dashboard bot added the will affect goldens label May 11, 2023

bdero approved these changes May 12, 2023

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023

auto-submit bot merged commit 502e1eb into flutter:main May 12, 2023

engine-flutter-autoroll mentioned this pull request May 12, 2023

Roll Flutter Engine from c784d6d4137d to 502e1eb591d9 (14 revisions) flutter/flutter#126714

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023

502e1eb [Impeller] starts running vulkan golden image tests with swif…

e5fcecc

…tshader (flutter/engine#41958)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] starts running vulkan golden image tests with swiftshader #41958

[Impeller] starts running vulkan golden image tests with swiftshader #41958

Uh oh!

gaaclarke commented May 11, 2023 •

edited

Loading

Uh oh!

gaaclarke May 11, 2023

Uh oh!

gaaclarke May 11, 2023

Uh oh!

flutter-dashboard bot commented May 11, 2023

Uh oh!

bdero left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Impeller] starts running vulkan golden image tests with swiftshader #41958

[Impeller] starts running vulkan golden image tests with swiftshader #41958

Uh oh!

Conversation

gaaclarke commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke May 11, 2023

Choose a reason for hiding this comment

Uh oh!

gaaclarke May 11, 2023

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented May 11, 2023

Uh oh!

bdero left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaaclarke commented May 11, 2023 •

edited

Loading