Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Switch back to shared buffer UI image uploading on iOS #42333

Closed
bdero wants to merge 1 commit into from
Closed

[Impeller] Switch back to shared buffer UI image uploading on iOS #42333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/ui/painting/image_decoder_impeller.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,13 +452,8 @@ void ImageDecoderImpeller::Decode(fml::RefPtr<ImageDescriptor> descriptor,
// texture is implemented on other platforms.
sk_sp<DlImage> image;
std::string decode_error;
#ifdef FML_OS_IOS
std::tie(image, decode_error) = UploadTextureToPrivate(
context, bitmap_result.device_buffer, bitmap_result.image_info);
#else
Comment on lines -455 to -458
Copy link
Contributor

@dnfield dnfield May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, you can use the GPU sync switch to conditionally use this path on iOS.

Copy link
Contributor

@jonahwilliams jonahwilliams May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to disable mipmaps as well

Copy link
Member Author

@bdero bdero May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned mipmaps in the description.

The blit pass that generates the mipmaps still fails if the app is backgrounded, but not writing all the mip levels is safe for Metal and Vulkan -- GLES is the problem child.

Copy link
Contributor

@dnfield dnfield May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On some versions of iOS we've seen crashes when accessing command encoders in the background

std::tie(image, decode_error) =
UploadTextureToShared(context, bitmap_result.sk_bitmap);
#endif
result(image, decode_error);
};
// TODO(jonahwilliams): https://github.com/flutter/flutter/issues/123058
Expand Down