This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add explicit color filter types to Aiks. #43342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/aiks-color-filters
branch
from
7385a98 to
013c386
Compare
bdero
force-pushed
the
bdero/aiks-color-filters
branch
2 times, most recently
from
55bef8a to
2e81a33
Compare
jonahwilliams
approved these changes
Jun 29, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
IIRC the last time we tried to land something like this all of the rendering broke in the gallery. Did we ever root cause that?
The change itself LGTM
Member
Author
|
Hmm, I don't recall landing something like this. Might you be referring to one of my previously failed ColorSource refactors that I had to roll back due to CPU benchmark regressions? I wound up taking a different approach for that in the end. In terms of avoiding fidelity regressions I think we've been doing pretty well now that we have a lot of stuff covered by goldens. |
Contributor
|
I'm thinking of this one: #37677 |
Contributor
|
I guess that was color sources and not filters. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
chinmaygarde
changed the title
bdero
force-pushed
the
bdero/aiks-color-filters
branch
from
4c22ffa to
c104b0b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 5, 2023
…30023) Manual roll Flutter Engine from 987b621 to bd2e42b (32 revisions) Manual roll requested by zra@google.com flutter/engine@987b621...bd2e42b 2023-07-05 zanderso@users.noreply.github.com Reverts Dart SDK to version 3.1.0-262.0.dev (flutter/engine#43417) 2023-07-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8YulTHvG-Jg3Sof-S... to C3Q7MJBYkiin8zw-f... (flutter/engine#43415) 2023-07-05 skia-flutter-autoroll@skia.org Roll Dart SDK from f7c242ded366 to e193587883d6 (1 revision) (flutter/engine#43414) 2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from a453fed07c91 to d58324bf653d (1 revision) (flutter/engine#43413) 2023-07-05 skia-flutter-autoroll@skia.org Roll Skia from faf906db84ab to a453fed07c91 (4 revisions) (flutter/engine#43412) 2023-07-05 skia-flutter-autoroll@skia.org Roll Dart SDK from c89f5ac4fd46 to f7c242ded366 (1 revision) (flutter/engine#43410) 2023-07-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8-taK-r4HkgVAIGtU... to 8YulTHvG-Jg3Sof-S... (flutter/engine#43409) 2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 7cd6ed860b63 to c89f5ac4fd46 (1 revision) (flutter/engine#43408) 2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from d128bd4977a7 to 7cd6ed860b63 (1 revision) (flutter/engine#43406) 2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from eaca275ef1c0 to faf906db84ab (1 revision) (flutter/engine#43405) 2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from e58e3bd3b507 to d128bd4977a7 (1 revision) (flutter/engine#43403) 2023-07-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from GNWxBcnfjZlyaOw34... to 8-taK-r4HkgVAIGtU... (flutter/engine#43402) 2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from bb18c9b1f730 to eaca275ef1c0 (1 revision) (flutter/engine#43401) 2023-07-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 604ccea2f5b9 to e58e3bd3b507 (1 revision) (flutter/engine#43400) 2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from 85a3fda32850 to bb18c9b1f730 (3 revisions) (flutter/engine#43399) 2023-07-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/engine#43398) 2023-07-04 skia-flutter-autoroll@skia.org Roll Skia from 4abc43e2ffcc to 85a3fda32850 (1 revision) (flutter/engine#43393) 2023-07-04 chinmaygarde@google.com [Impeller] Document `impeller::Context`. (flutter/engine#43389) 2023-07-03 skia-flutter-autoroll@skia.org Roll Dart SDK from a4c5ed075a2b to 604ccea2f5b9 (1 revision) (flutter/engine#43390) 2023-07-03 skia-flutter-autoroll@skia.org Roll Dart SDK from c092e09b7e64 to a4c5ed075a2b (1 revision) (flutter/engine#43387) 2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from 6a5ea15c942b to 4abc43e2ffcc (1 revision) (flutter/engine#43386) 2023-07-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from cytps4RRhs8-wbcVJ... to GNWxBcnfjZlyaOw34... (flutter/engine#43373) 2023-07-03 skia-flutter-autoroll@skia.org Roll Dart SDK from dedff8f0ebd2 to c092e09b7e64 (1 revision) (flutter/engine#43374) 2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from 94ad507b8959 to 6a5ea15c942b (1 revision) (flutter/engine#43385) 2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) (flutter/engine#43383) 2023-07-03 skia-flutter-autoroll@skia.org Roll Skia from 384b84445a9f to e16d5b988a36 (1 revision) (flutter/engine#43382) 2023-07-02 skia-flutter-autoroll@skia.org Roll Skia from dbf0829114ee to 384b84445a9f (2 revisions) (flutter/engine#43381) 2023-07-01 bdero@google.com [Impeller] Remove blend mode restrictions on clear color optimization (flutter/engine#43348) 2023-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from f00f7363f4bf to dedff8f0ebd2 (4 revisions) (flutter/engine#43371) 2023-07-01 skia-flutter-autoroll@skia.org Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) (flutter/engine#43370) 2023-07-01 bdero@google.com [Impeller] Add explicit color filter types to Aiks. (flutter/engine#43342) 2023-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 2d98d9e27dae to f00f7363f4bf (1 revision) (flutter/engine#43354) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from cytps4RRhs8- to C3Q7MJBYkiin If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose ...
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Part of flutter/flutter#127232. Adds an explicit ColorFilter concept to Aiks which wraps the GPU and CPU implementations. We're not using the CPU implementations yet, but I'll be getting it wired up in a follow-up patch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#127232.
Adds an explicit ColorFilter concept to Aiks which wraps the GPU and CPU implementations. We're not using the CPU implementations yet, but I'll be getting it wired up in a follow-up patch.