Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Remove image codecs from CanvasKit Chromium (again) #43346

Closed
mdebbar wants to merge 9 commits into from
Closed

[web] Remove image codecs from CanvasKit Chromium (again) #43346

mdebbar wants to merge 9 commits into from

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 29, 2023 •
edited
Loading

First attempt was made at #40309

  • Handle targetWidth and targetHeight using our ResizingCodec.
  • Add some asserts to prevent calling the wrong decoding methods.
  • Fix an issue with FlutterConfiguration being reset to the wrong value in tests.
  • In Chromium mode, skip tests that exercise CanvasKit image codecs directly.

Fixes flutter/flutter#122331

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Jun 29, 2023
@mdebbar mdebbar force-pushed the image_codecs_resize branch from c90e5e1 to da69f85 Compare July 20, 2023 20:23
@mdebbar
Copy link
Contributor Author

mdebbar commented Sep 19, 2023

I'll come back to this later.

@mdebbar mdebbar closed this Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] Remove image codecs from CanvasKit Chromium

1 participant

@mdebbar