This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Read platform kernel blob from asset directory instead of FLX #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| struct stat stat_result = {}; | ||
| if (::stat(bundle_path.c_str(), &stat_result) == 0) { | ||
| std::unique_ptr<DirectoryAssetBundle> directory_asset_bundle; |
Contributor
There was a problem hiding this comment.
This should be merged with your other change, and become a fxl::RefPtr<>, right?
Contributor
|
@szakarias Is this PR still live? |
Contributor
Author
|
No, sorry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4343 and should not be merged until that lands along with flutter/flutter#12944.
The diff for this PR can be viewed here
szakarias/engine@flutterAssets...szakarias:kernel