Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix Platform.localeName by setting _Platform._localeClosure #4450

Merged
zanderso merged 1 commit into from
Dec 12, 2017
Merged

Fix Platform.localeName by setting _Platform._localeClosure #4450

zanderso merged 1 commit into from
Dec 12, 2017

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Dec 12, 2017 •
edited
Loading

Hixie
Hixie reviewed Dec 12, 2017
View reviewed changes
lib/ui/hooks.dart Outdated

String _localeClosure() => window._locale.toString();

Function _getLocaleClosure() => _localeClosure;
Copy link
Contributor

@Hixie Hixie Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to use a typedef?

Copy link
Member Author

@zanderso zanderso Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

rmacnak-google
rmacnak-google approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@rmacnak-google rmacnak-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zanderso zanderso merged commit df18819 into flutter:master Dec 12, 2017
@zanderso zanderso deleted the set-locale-closure branch December 12, 2017 23:01
@aam
Copy link
Member

aam commented Dec 13, 2017

@zanderso have you tried running flutter gallery with this engine change?
As @crelier is trying to do daily dart roll he is hitting issue running flutter gallery in release mode: #4343 (comment)

@zanderso
Copy link
Member Author

zanderso commented Dec 13, 2017

Yes. There is a bug in flutter_tool here: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/build_aot.dart#L196 in which it fails to use the updated libraries from the local engine. A temporary workaround is to manually copy //engine/src/flutter/lib/ui/hooks.dart to //flutter/bin/cache/pkg/sky_engine/lib/ui/hooks.dart and //flutter/bin/cache/pkg/sky_engine/sdk_ext/hooks.dart.

@Hixie
Copy link
Contributor

Hixie commented Dec 13, 2017

When running into a bug, please feel empowered to fix the bug rather than just work around it. :-)

This was referenced Dec 22, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Hixie Hixie Hixie left review comments

@rmacnak-google rmacnak-google rmacnak-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanderso @aam @Hixie @rmacnak-google @googlebot