Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@brianosman
Copy link
Contributor

SkPixelSerializer has been removed, and the default behavior for SkPicture serialization is the same as what was being done here before.

@brianosman
Copy link
Contributor Author

Hmm - I didn't modify the file that's failing the format check. How did that land originally?

@jason-simmons
Copy link
Member

The format warning was introduced by #4471

Looks like that PR didn't pass the Travis check:
https://travis-ci.org/flutter/engine/builds/318042055?utm_source=github_status&utm_medium=notification

@brianosman brianosman merged commit 6bb7764 into flutter:master Dec 18, 2017
@brianosman brianosman deleted the pixelref branch December 18, 2017 20:45
@Hixie
Copy link
Contributor

Hixie commented Dec 21, 2017

When this rolled into Flutter in flutter/flutter#13696, there was a more than 2x regression on flutter_gallery__transition_perf worst_frame_rasterizer_time_millis. This is not the only commit that was involved, but it's the most suspicious.

@brianosman
Copy link
Contributor Author

Here's the list of Skia commits included in that roll: https://skia.googlesource.com/skia.git/+log/58a3fcd4..ef038483

Eyeballing the list - ~140 commits? Is it easy to reproduce this, to perform some kind of bisect (into the roll)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants