This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add zip asset store to AssetFontSelector #4475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime/asset_font_selector.cc
Outdated
|
|
||
| void AssetFontSelector::parseFontManifest() { | ||
| std::vector<uint8_t> font_manifest_data; | ||
| if (!directory_asset_bundle_->GetAsBuffer(kFontManifestAssetPath, |
Contributor
There was a problem hiding this comment.
Since the AssetFontSelector is now initialized with either a DirectoryAssetBundle or a ZipAssetStore, don't we need null checks on directory_asset_bundle_ and asset_store_?
szakarias
force-pushed
the
fuchsiaFonts
branch
from
346c56d to
6eaf7a3
Compare
Contributor
Author
Contributor
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix until Fuchsia doesn't use flx anymore.