This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Remove deprecated MOCK_METHODx calls" #45431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 81ed971.
Contributor
|
I couldn't tell what the error was. |
Contributor
Author
|
I couldn't either. I ran one of the tests and it passed. Let me run them all. |
Contributor
|
Is this still necessary? |
Contributor
Author
|
I've close the internal issue with the following note: I've created a CL for this PR and ran it in a Global TAP train. There're a few failures, but none of them are the same as the failures in this report (also some of them are SCUBA rasterization errors). I think it's safe to consider all of them flakes. |
Contributor
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45307 due to internal breakage. b/298953971