Delete ci/lint.sh, which is no longer used.

.clang-tidy

@@ -1,8 +1,6 @@
 # A YAML format of https://clang.llvm.org/extra/clang-tidy/.
 
 # Prefix check with "-" to ignore.
-# Note: Some of the checks here are used as errors selectively, see
-# //ci/lint.sh
 Checks: >-
   bugprone-use-after-move,
   bugprone-unchecked-optional-access,

ci/builders/README.md

@@ -464,7 +464,7 @@ Engine test example:
 {
   "tests": [
     {
-       "name": "test: lint android_debug_arm64",
+       "name": "test: clang_tidy android_debug_arm64",
        "recipe": "engine_v2/tester_engine",
        "drone_dimensions": [
          "device_type=none",
@@ -476,7 +476,7 @@ Engine test example:
        ],
        "tasks": [
          {
-            "name": "test: lint android_debug_arm64",
+            "name": "test: clang_tidy android_debug_arm64",
             "parameters": [
               "--variant",
               "android_debug_arm64",
@@ -485,7 +485,7 @@ Engine test example:
               "--shard-variants=host_debug"
             ],
             "max_attempts": 1,
-            "script": "flutter/ci/lint.sh"
+            "script": "flutter/ci/clang_tidy.sh"
          }
        ]
     }
@@ -513,7 +513,7 @@ Example task configuration:
 
 ```json
 {
-    "name": "test: lint android_debug_arm64",
+    "name": "test: clang_tidy android_debug_arm64",
     "parameters": [
        "--variant",
        "android_debug_arm64",
@@ -522,7 +522,7 @@ Example task configuration:
        "--shard-variants=host_debug"
     ],
     "max_attempts": 1,
-    "script": "flutter/ci/lint.sh"
+    "script": "flutter/ci/clang_tidy.sh"
 }
 ```
 

ci/clang_tidy.sh

@@ -36,10 +36,14 @@ DART="${DART_BIN}/dart"
 # FLUTTER_LINT_PRINT_FIX will make it so that fix is executed and the generated
 # diff is printed to stdout if clang-tidy fails. This is helpful for enabling
 # new lints.
+
+# To run on CI, just uncomment the following line:
+# FLUTTER_LINT_PRINT_FIX=1
+
 if [[ -z "${FLUTTER_LINT_PRINT_FIX}" ]]; then
   fix_flag=""
 else
-  fix_flag="--fix"
+  fix_flag="--fix --lint-all"
 fi
 
 COMPILE_COMMANDS="$SRC_DIR/out/host_debug/compile_commands.json"

tools/githooks/README.md

@@ -21,8 +21,8 @@ scripts have the names that `git` will look for.
 This hooks runs when pushing commits to a remote branch, for example to
 create or update a pull request: `git push origin my-local-branch`.
 
-The `pre-push` hook runs `ci/lint.sh` and `ci/format.sh`. `ci/analyze.sh` and
-`ci/licenses.sh` are more expensive and are not run.
+The `pre-push` hook runs `ci/clang_tidy.sh`, `ci/pylint.sh` and `ci/format.sh`.
+`ci/analyze.sh` and `ci/licenses.sh` are more expensive and are not run.
 
 ### Adding new pre-push checks