This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] made window size parametric in playground/golden tests #46682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
golden-window-size
branch
2 times, most recently
from
e8e510c to
31e606b
Compare
gaaclarke
force-pushed
the
golden-window-size
branch
from
31e606b to
2c814c0
Compare
bdero
approved these changes
Oct 10, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2023
flutter/engine@60e861d...39bfce2 2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c634411c51e6 to f0653c4a2df5 (1 revision) (flutter/engine#46716) 2023-10-10 30870216+gaaclarke@users.noreply.github.com [Impeller] made window size parametric in playground/golden tests (flutter/engine#46682) 2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c497dae2fedb to c634411c51e6 (1 revision) (flutter/engine#46714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…6682) In flutter/flutter#136058 (comment) it was seen that some bugs manifest only with viewports of certain sizes. This allows writers of tests to adjust the window size for playgrounds and golden image tests. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In flutter/flutter#136058 (comment) it was seen that some bugs manifest only with viewports of certain sizes. This allows writers of tests to adjust the window size for playgrounds and golden image tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.