Make impeller/geometry/... compatible with .clang-tidy.

impeller/archivist/archive.h

@@ -21,7 +21,7 @@ class ArchiveDatabase;
 
 class Archive {
  public:
-  Archive(const std::string& path);
+  explicit Archive(const std::string& path);
 
   ~Archive();
 
@@ -45,7 +45,7 @@ class Archive {
 
   template <class T,
             class = std::enable_if_t<std::is_base_of<Archivable, T>::value>>
-  [[nodiscard]] size_t Read(UnarchiveStep stepper) {
+  [[nodiscard]] size_t Read(const UnarchiveStep& stepper) {
     const ArchiveDef& def = T::kArchiveDefinition;
     return UnarchiveInstances(def, stepper);
   }

impeller/archivist/archive_database.h

@@ -22,7 +22,7 @@ struct ArchiveDef;
 ///
 class ArchiveDatabase {
  public:
-  ArchiveDatabase(const std::string& filename);
+  explicit ArchiveDatabase(const std::string& filename);
 
   ~ArchiveDatabase();
 

impeller/archivist/archive_vector.h

@@ -28,7 +28,7 @@ class ArchiveVector : public Archivable {
 
   ArchiveVector();
 
-  ArchiveVector(std::vector<int64_t> keys);
+  explicit ArchiveVector(std::vector<int64_t> keys);
 
   ArchiveVector(const ArchiveVector&) = delete;
 

impeller/compiler/compiler_backend.h

@@ -47,7 +47,7 @@ struct CompilerBackend {
 
   spirv_cross::Compiler* GetCompiler();
 
-  operator bool() const;
+  explicit operator bool() const;
 
   enum class ExtendedResourceIndex {
     kPrimary,

impeller/compiler/logger.h

@@ -15,7 +15,7 @@ namespace compiler {
 
 class AutoLogger {
  public:
-  AutoLogger(std::stringstream& logger) : logger_(logger) {}
+  explicit AutoLogger(std::stringstream& logger) : logger_(logger) {}
 
   ~AutoLogger() {
     logger_ << std::endl;

impeller/core/vertex_buffer.h

@@ -17,7 +17,7 @@ struct VertexBuffer {
   size_t vertex_count = 0u;
   IndexType index_type = IndexType::kUnknown;
 
-  constexpr operator bool() const {
+  constexpr explicit operator bool() const {
     return static_cast<bool>(vertex_buffer) &&
            (index_type == IndexType::kNone || static_cast<bool>(index_buffer));
   }

impeller/entity/contents/filters/inputs/texture_filter_input.h

@@ -31,8 +31,8 @@ class TextureFilterInput final : public FilterInput {
   Matrix GetLocalTransform(const Entity& entity) const override;
 
  private:
-  TextureFilterInput(std::shared_ptr<Texture> texture,
-                     Matrix local_transform = Matrix());
+  explicit TextureFilterInput(std::shared_ptr<Texture> texture,
+                              Matrix local_transform = Matrix());
 
   std::shared_ptr<Texture> texture_;
   Matrix local_transform_;

impeller/geometry/color.h

@@ -840,10 +840,14 @@ struct Color {
 
   static Color Random() {
     return {
+        // This method is not used for cryptographic purposes.
+        // NOLINTBEGIN(clang-analyzer-security.insecureAPI.rand)
         static_cast<Scalar>((std::rand() % 255) / 255.0f),  //
         static_cast<Scalar>((std::rand() % 255) / 255.0f),  //
         static_cast<Scalar>((std::rand() % 255) / 255.0f),  //
-        1.0f                                                //
+        // NOLINTEND(clang-analyzer-security.insecureAPI.rand)
+        1.0f  //
+
     };
   }
 

impeller/geometry/path.cc

@@ -228,20 +228,20 @@ bool Path::GetContourComponentAtIndex(size_t index,
 
 Path::Polyline::Polyline(Path::Polyline::PointBufferPtr point_buffer,
                          Path::Polyline::ReclaimPointBufferCallback reclaim)
-    : points(std::move(point_buffer)), reclaim_points(std::move(reclaim)) {
+    : points(std::move(point_buffer)), reclaim_points_(std::move(reclaim)) {
   FML_DCHECK(points);
 }
 
 Path::Polyline::Polyline(Path::Polyline&& other) {
   points = std::move(other.points);
-  reclaim_points = std::move(other.reclaim_points);
+  reclaim_points_ = std::move(other.reclaim_points_);
   contours = std::move(other.contours);
 }
 
 Path::Polyline::~Polyline() {
-  if (reclaim_points) {
+  if (reclaim_points_) {
     points->clear();
-    reclaim_points(std::move(points));
+    reclaim_points_(std::move(points));
   }
 }
 

impeller/geometry/path.h

@@ -125,7 +125,7 @@ class Path {
         size_t contour_index) const;
 
    private:
-    ReclaimPointBufferCallback reclaim_points;
+    ReclaimPointBufferCallback reclaim_points_;
   };
 
   Path();

impeller/geometry/path_component.h

@@ -102,7 +102,7 @@ struct CubicPathComponent {
 
   CubicPathComponent() {}
 
-  CubicPathComponent(const QuadraticPathComponent& q)
+  explicit CubicPathComponent(const QuadraticPathComponent& q)
       : p1(q.p1),
         cp1(q.p1 + (q.cp - q.p1) * (2.0 / 3.0)),
         cp2(q.p2 + (q.cp - q.p2) * (2.0 / 3.0)),
@@ -148,7 +148,7 @@ struct ContourComponent {
 
   ContourComponent() {}
 
-  ContourComponent(Point p, bool is_closed = false)
+  explicit ContourComponent(Point p, bool is_closed = false)
       : destination(p), is_closed(is_closed) {}
 
   bool operator==(const ContourComponent& other) const {

impeller/geometry/rect.h

@@ -9,6 +9,7 @@
 #include <ostream>
 #include <vector>
 
+#include "fml/logging.h"
 #include "impeller/geometry/matrix.h"
 #include "impeller/geometry/point.h"
 #include "impeller/geometry/scalar.h"
@@ -211,7 +212,11 @@ struct TRect {
   ///         rectangle.
   constexpr TRect TransformBounds(const Matrix& transform) const {
     auto points = GetTransformedPoints(transform);
-    return TRect::MakePointBounds(points.begin(), points.end()).value();
+    auto bounds = TRect::MakePointBounds(points.begin(), points.end());
+    if (bounds.has_value()) {
+      return bounds.value();
+    }
+    FML_UNREACHABLE();
   }
 
   /// @brief  Constructs a Matrix that will map all points in the coordinate