Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mk12
Copy link
Contributor

@mk12 mk12 commented Jan 30, 2024

To pick up flutter/buildroot#821, which completed the migration to the fidlgen_cpp tables.c file.

This will unblock landing https://fxrev.dev/953990, which removes the fidlc --tables flag.

This work is tracked in https://fxbug.dev/42115242.

@mk12 mk12 requested a review from jrwang January 30, 2024 00:28
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mk12 mk12 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit auto-submit bot merged commit 8aff8b0 into flutter:main Jan 30, 2024
@mk12 mk12 deleted the roll-buildroot-821 branch January 30, 2024 18:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 30, 2024
flutter/engine@0e4342c...cd12316

2024-01-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179)
2024-01-30 30870216+gaaclarke@users.noreply.github.com [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157)
2024-01-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175)
2024-01-30 jonahwilliams@google.com [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122)
2024-01-30 mk12360@gmail.com Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants