-
Notifications
You must be signed in to change notification settings - Fork 6k
#145421 Fix glyph padding in STB atlas impl. #51585
#145421 Fix glyph padding in STB atlas impl. #51585
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Fixes incorrect glyph padding in the STB based Glyph Atlas.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
auto label is removed for flutter/engine/51585, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
flutter/engine@e3104af...dcc99d6 2024-04-04 dkwingsmt@users.noreply.github.com Multiview backing store (flutter/engine#51722) 2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from f9dfb0308594 to 8ad03dfe4e2e (2 revisions) (flutter/engine#51915) 2024-04-04 43091780+utzcoz@users.noreply.github.com Bump Robolectric to 4.12.1 (flutter/engine#51800) 2024-04-04 johnoneil@users.noreply.github.com #145421 Fix glyph padding in STB atlas impl. (flutter/engine#51585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…6308) flutter/engine@e3104af...dcc99d6 2024-04-04 dkwingsmt@users.noreply.github.com Multiview backing store (flutter/engine#51722) 2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from f9dfb0308594 to 8ad03dfe4e2e (2 revisions) (flutter/engine#51915) 2024-04-04 43091780+utzcoz@users.noreply.github.com Bump Robolectric to 4.12.1 (flutter/engine#51800) 2024-04-04 johnoneil@users.noreply.github.com flutter#145421 Fix glyph padding in STB atlas impl. (flutter/engine#51585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
See the associated issue for description and screenshots.
Fixes issue #145421 as described here.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.