[CP][Android] Fix the issue of blank or frozen pages in shared engine scenarios #50947 #52387
Conversation
…narios (flutter#50947) Consider this scenario: In an add-to-app context, where multiple Flutter activities share the same engine, a situation occurs. When navigating from FlutterActivity1 to FlutterActivity2, the Flutter view associated with FlutterActivity1 is detached from the engine. Then, the Flutter view of FlutterActivity2 is attached. Upon navigating back to FlutterActivity1, its Flutter view is re-attached to the shared engine. The expected behavior is: When a Flutter view detaches from the shared engine, the associated surface should be released. When the Flutter view re-attaches, a new surface should be created. After flutter#47358, no new surface is created when the Flutter view is attached again. This results in the Flutter view having no underlying surface, which causes the page to appear blank or freeze without responding. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mdnht
force-pushed
the
cp_f9a34ae0b14f4dfd6a8cf9181ab5db3c14c0246d
branch
from
d74a42f to
96736f6
Compare
|
I have fixed CI check failure. Could you give a review now? @johnmccutchan @reidbaker |
|
It might be too late to CP into 3.19. I am double checking with the release manager now. |
|
@reidbaker @itsjustkevin We have a product using add2App app using shared engine for both android and ios, and because of Apple Privacy Manifest requirement Flutter needs to be 3.19 and above. |
|
I talked to the release manager and it is too late to accepts 3.19 cherry picks but I do appreciate you trying to land this. |
3 participants
Cherry picked f9a34ae
From [Android] Fix the issue of blank or frozen pages in shared engine scenarios