[DisplayList] collect clear colors from rendering ops #53214
Conversation
| return true; | ||
| } | ||
|
|
||
| bool DisplayListBuilder::LayerInfo::update_clear_color(DlColor color, |
There was a problem hiding this comment.
The render target's clear color will ignore all clips, so any time we add a non-culled clip to the builder we have to turn off clear color optimization.
This is makes clip culling is super important
There was a problem hiding this comment.
Because of this actually, we may need to do clear color optimization while dispatching instead of recording, but lets discuss today and see if folks have ideas.
There was a problem hiding this comment.
I thought of that last night. I was thinking that turning off the optimization after receiving a clip would do the trick there, but there is also the fact that the DL Builder is still figuring out the right bounds for the save layer while it is recording and won't know the true bounds until Restore is called. So, perhaps this entire optimization is not possible. Or perhaps it only works for DrawColor and DrawPaint that happen right after a SaveLayer but before any clips.
We'll discuss later...
There was a problem hiding this comment.
I should probably transfer all of the new code to the clip functions to cull unnecessary clips even if it doesn't get used for clear color overlap detection...
| bool DisplayListBuilder::LayerInfo::update_clear_color(DlColor color, | ||
| DlBlendMode mode) { | ||
| if (still_clearing) { | ||
| switch (mode) { |
There was a problem hiding this comment.
We should be able to support all blend modes, if we clear more than 1 color we perform the blending on the CPU. clear color should not impact max_blend_mode I think
|
This work was redirected into #53367 after concluding that the appropriate information to know what size destination the rendering ops are targeting is not always available at the DisplayList recording level. |
2 participants
The DisplayList will now detect simple single-color rendering ops that cover the entire renderable surface and collect their colors into a "layer clear color" so that the rendering back ends can optimize the initialization of saveLayers.