This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. #55416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.storeAction = StoreAction.store, | ||
| this.clearValue = const ui.Color(0x00000000), | ||
| // TODO(bdero): Why can't vm.Vector4 constructors be const? | ||
| vm.Vector4? clearValue = null, |
Contributor
There was a problem hiding this comment.
Vector4 (and all vector math classes) are backed by a fixed size TypedData array that aren't const constructable.
Member
Author
There was a problem hiding this comment.
Meh, oh well. :/ Thanks for taking a look.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2024
flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…55733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…55733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…55733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…55733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#155627.
Allow setting the clear directly as floats without conversion work. vector_math already has convenient
Colors.[color]factories and such. Also,ui.Colorhas a color space now, which does not apply here.Adds a simple golden to verify that clear colors work:
