This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] libImpeller: Allow appending to the transformation stack. #56072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently @lyceel has a workaround where they get the transform, create a new one, and call SetTransform. They would like to avoid this. Fixes flutter/flutter#156604
chinmaygarde
added
the
e: libimpeller
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2024
flutter/engine@5d7caf7...0b56cb8 2024-10-24 31859944+LongCatIsLooong@users.noreply.github.com Bare-bones iOS FKA implementation (flutter/engine#55964) 2024-10-23 chinmaygarde@google.com [Impeller] libImpeller: Allow appending to the transformation stack. (flutter/engine#56072) 2024-10-23 magder@google.com Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orchestrator (flutter/engine#56014) 2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 75c42f30af7a to dd06a1e3002c (2 revisions) (flutter/engine#56070) 2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from 42f9070e6625 to 53c9663c3b83 (1 revision) (flutter/engine#56069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…7486) flutter/engine@5d7caf7...0b56cb8 2024-10-24 31859944+LongCatIsLooong@users.noreply.github.com Bare-bones iOS FKA implementation (flutter/engine#55964) 2024-10-23 chinmaygarde@google.com [Impeller] libImpeller: Allow appending to the transformation stack. (flutter/engine#56072) 2024-10-23 magder@google.com Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orchestrator (flutter/engine#56014) 2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 75c42f30af7a to dd06a1e3002c (2 revisions) (flutter/engine#56070) 2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from 42f9070e6625 to 53c9663c3b83 (1 revision) (flutter/engine#56069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…lutter/engine#56072) Currently @lyceel has a workaround where they get the transform, create a new one, and call SetTransform. They would like to avoid this. Fixes flutter#156604
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently @lyceel has a workaround where they get the transform, create a new one, and call SetTransform. They would like to avoid this.
Fixes flutter/flutter#156604