[engine] Migrate fuchsia.io Open functions to Open3 #56818

Breakthrough · 2024-11-26T19:15:23Z

Migrate the use of fuchsia.io open functions to the new open3 replacements (which also requires transitioning from OpenFlags -> Flags). Likewise, we update all uses of the SDK VFS library to use the new set of flags.

This work is being done as part of the ongoing io2 migration in https://fxbug.dev/378924259

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA. (I am a Googler)
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-11-26T19:15:26Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard · 2024-11-26T19:57:47Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

zijiehe-google-com · 2024-11-27T21:11:39Z

@abarth may take a look.

abarth · 2024-11-28T00:20:44Z

LGTM

stuartmorgan-g · 2024-12-02T00:42:14Z

test-exempt: code refactor with no semantic change

chinmaygarde

RSLGTM

chinmaygarde · 2024-12-09T18:57:06Z

May I submit this?

auto-submit · 2024-12-09T21:04:10Z

auto label is removed for flutter/engine/56818, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Breakthrough · 2024-12-09T21:09:51Z

May I submit this?

Yes please do! Thanks all for reviewing.

The fdio library *_at functions work correctly with AT_FDCWD now, so we can reduce some code duplication for special cases. These library functions internally already call the *_at version with AT_FDCWD.

These functions are in the process of being deprecated, with Open -> Open3 and OpenFlags -> Flags. See https://fxbug.dev/378924259 for additional context.

Migrate vfs::PseudoDir::Serve to use the new typed channel replacement, which is already available at all supported API levels. The previous signature is deprecated as of Fuchsia API level 25. See https://fxbug.dev/378924259 for additional context.

These were added in flutter#50358 as we were originally planning on removing the vfs::ComposedPseudoDir and vfs::LazyDir types from the SDK VFS. However, we have dropped the deprecation in https://fxrev.dev/1123733 and are supporting these at all current API levels again.

This completes the migration as part of https://fxbug.dev/378924259

jonahwilliams

LGTM

…engine#56818)

flutter/engine@58e5f9b...23fc43d 2024-12-10 chris@bracken.jp iOS: Add null checks on shell dereference (flutter/engine#57099) 2024-12-10 Breakthrough@users.noreply.github.com [engine] Migrate fuchsia.io Open functions to Open3 (flutter/engine#56818) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…6818) Migrate the use of fuchsia.io open functions to the new open3 replacements (which also requires transitioning from OpenFlags -> Flags). Likewise, we update all uses of the SDK VFS library to use the new set of flags. This work is being done as part of the ongoing io2 migration in https://fxbug.dev/378924259 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

github-actions bot added the platform-fuchsia label Nov 26, 2024

Breakthrough force-pushed the b/378924259 branch 2 times, most recently from 8a24284 to 00ab4f2 Compare November 26, 2024 19:51

Breakthrough marked this pull request as draft November 26, 2024 19:54

Breakthrough force-pushed the b/378924259 branch 5 times, most recently from aa9e453 to 51aed20 Compare November 26, 2024 23:11

Breakthrough marked this pull request as ready for review November 26, 2024 23:35

Breakthrough force-pushed the b/378924259 branch from 51aed20 to 0dc8255 Compare November 27, 2024 18:31

chinmaygarde requested a review from a team November 27, 2024 21:04

Breakthrough force-pushed the b/378924259 branch from f733896 to 7e946c0 Compare November 28, 2024 15:52

chinmaygarde approved these changes Dec 2, 2024

View reviewed changes

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024

Breakthrough added 5 commits December 10, 2024 13:03

[fuchsia] Use AT_FDCWD with fdio_open*_at

41a0a8e

The fdio library *_at functions work correctly with AT_FDCWD now, so we can reduce some code duplication for special cases. These library functions internally already call the *_at version with AT_FDCWD.

[fuchsia] Migrate fdio_open_* -> fdio_open3_*

3928351

These functions are in the process of being deprecated, with Open -> Open3 and OpenFlags -> Flags. See https://fxbug.dev/378924259 for additional context.

[fuchsia] Migrate away from Clone and open /svc with permissions

30cb2bc

This completes the migration as part of https://fxbug.dev/378924259

Breakthrough force-pushed the b/378924259 branch from 7e946c0 to 30cb2bc Compare December 10, 2024 18:03

jonahwilliams approved these changes Dec 10, 2024

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2024

auto-submit bot merged commit 3f79627 into flutter:main Dec 10, 2024
29 checks passed

engine-flutter-autoroll mentioned this pull request Dec 10, 2024

Roll Flutter Engine from 58e5f9b3df54 to 23fc43d5e61f (2 revisions) flutter/flutter#160044

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2024

3f79627 [engine] Migrate fuchsia.io Open functions to Open3 (flutter/…

370b690

…engine#56818)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[engine] Migrate fuchsia.io Open functions to Open3 #56818

[engine] Migrate fuchsia.io Open functions to Open3 #56818

Uh oh!

Breakthrough commented Nov 26, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Nov 26, 2024

Uh oh!

flutter-dashboard bot commented Nov 26, 2024

Uh oh!

zijiehe-google-com commented Nov 27, 2024

Uh oh!

abarth commented Nov 28, 2024

Uh oh!

stuartmorgan-g commented Dec 2, 2024

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde commented Dec 9, 2024

Uh oh!

auto-submit bot commented Dec 9, 2024

Uh oh!

Breakthrough commented Dec 9, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[engine] Migrate fuchsia.io Open functions to Open3 #56818

[engine] Migrate fuchsia.io Open functions to Open3 #56818

Uh oh!

Conversation

Breakthrough commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Nov 26, 2024

Uh oh!

flutter-dashboard bot commented Nov 26, 2024

Uh oh!

zijiehe-google-com commented Nov 27, 2024

Uh oh!

abarth commented Nov 28, 2024

Uh oh!

stuartmorgan-g commented Dec 2, 2024

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Dec 9, 2024

Uh oh!

auto-submit bot commented Dec 9, 2024

Uh oh!

Breakthrough commented Dec 9, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Breakthrough commented Nov 26, 2024 •

edited

Loading