This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove touch mapper and respect the UITouch phase when calculating the pointer data change type. #6430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
approved these changes
Oct 4, 2018
shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
| // Dispatches the UITouches to the engine. Usually, the type of change of the touch is determined | ||
| // from the UITouch's phase. However, the AppDelegate fakes touches to simulate status bar touches | ||
| // when the Flutter view is no full screen. The change type of the faked touch is specified in the | ||
| // second argument. If the `overridden_change` is nullptr, the change type is determined from |
Member
There was a problem hiding this comment.
'change' seems like a non-term-of-art wording. Should we call it phase_override or something?
Contributor
Author
There was a problem hiding this comment.
I was using the PointerData::Change enum as the basis of that wording.
cbracken
approved these changes
Oct 4, 2018
Member
|
|
…e pointer data change type. The touch mapper was a relic of a time when the pointer IDs had to be less than 16. Not respecting the touch phase is getting in the way of clients that fake their own touches. Turns out the AppDelegate also like to fake touches to simulate status bar events. Now, except in cases where there is a specific override in place, the UI touch phase is respected.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@c8755d7...45c5fe5 git log c8755d7..45c5fe5 --no-merges --oneline 45c5fe5 Remove touch mapper and respect the UITouch phase when calculating the pointer data change type. (flutter/engine#6430) 2347368 Roll src/third_party/skia 66a973493468..d95303e10cbc (13 commits) (flutter/engine#6440) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 5, 2018
flutter/engine@c8755d7...45c5fe5 git log c8755d7..45c5fe5 --no-merges --oneline 45c5fe5 Remove touch mapper and respect the UITouch phase when calculating the pointer data change type. (flutter/engine#6430) 2347368 Roll src/third_party/skia 66a973493468..d95303e10cbc (13 commits) (flutter/engine#6440) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/engine
that referenced
this pull request
Nov 15, 2018
…e pointer data change type. (flutter#6430) The touch mapper was a relic of a time when the pointer IDs had to be less than 16. Not respecting the touch phase is getting in the way of clients that fake their own touches. Turns out the AppDelegate also like to fake touches to simulate status bar events. Now, except in cases where there is a specific override in place, the UI touch phase is respected.
kangwang1988
added a commit
to XianyuTech/engine
that referenced
this pull request
Nov 15, 2018
…ating the pointer data change type. (flutter#6430)" This reverts commit b871213.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The touch mapper was a relic of a time when the pointer IDs had to be less
than 16. Not respecting the touch phase is getting in the way of clients that
fake their own touches. Turns out the AppDelegate also like to fake touches to
simulate status bar events. Now, except in cases where there is a specific
override in place, the UI touch phase is respected.