This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Pass scriptCode to engine and addd iOS Chinese locale hack to ameliorate Chinese l10n. #6483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate Chinese l10n.
Contributor
|
I think we should just solve this the proper way, no need for a temporary hack. |
Contributor
Author
|
#6493 is the more complete script code + variant code passing. I can close this and just work on the full version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not support the more detailed locales provided by iOS. The result is that without the Script Code data, we are incorrectly choosing simplified/traditional Chinese depending on whichever language is listed first as supported.
This is a hack that temporarily makes this problem better as I work on expanding the Localization APIs to fully support the more nuanced locales.