This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensure that the isolate shutdown callback occurs in an isolate scope. #6572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2018
flutter/engine@04c860f...8cc49ca git log 04c860f..8cc49ca --no-merges --oneline 8cc49ca Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572) 04a1ffa Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571) 35340ce Pass full locale list with script and variant codes to framework (flutter/engine#6557) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Oct 17, 2018
And update goldens. git log 04c860f..8cc49ca --no-merges --oneline 8cc49ca Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572) 04a1ffa Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571) 35340ce Pass full locale list with script and variant codes to framework (flutter/engine#6557)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2018
flutter/engine@04c860f...705738f git log 04c860f..705738f --no-merges --oneline 705738f Roll src/third_party/skia 3a0c66da5fc2..928db927f7fc (5 commits) (flutter/engine#6573) 8cc49ca Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572) 04a1ffa Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571) 35340ce Pass full locale list with script and variant codes to framework (flutter/engine#6557) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2018
flutter/engine@04c860f...979de07 git log 04c860f..979de07 --no-merges --oneline 979de07 Add a CountDownLatch to fml with tests. (flutter/engine#6574) 705738f Roll src/third_party/skia 3a0c66da5fc2..928db927f7fc (5 commits) (flutter/engine#6573) 8cc49ca Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572) 04a1ffa Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571) 35340ce Pass full locale list with script and variant codes to framework (flutter/engine#6557) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2018
flutter/engine@04c860f...607c05c git log 04c860f..607c05c --no-merges --oneline 607c05c Run all supported host unit tests on Cirrus. (flutter/engine#6575) 979de07 Add a CountDownLatch to fml with tests. (flutter/engine#6574) 705738f Roll src/third_party/skia 3a0c66da5fc2..928db927f7fc (5 commits) (flutter/engine#6573) 8cc49ca Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572) 04a1ffa Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571) 35340ce Pass full locale list with script and variant codes to framework (flutter/engine#6557) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
added a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2018
And update goldens. git log 04c860f..8cc49ca --no-merges --oneline 8cc49ca Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572) 04a1ffa Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571) 35340ce Pass full locale list with script and variant codes to framework (flutter/engine#6557)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers to grab stuff out of the isolate (like exception handle) before the isolate goes away.