This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename Widget.root to Widget.renderObject #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name `root` is confusing because this value isn't the root of anything. It's just the associated `RenderObject` instance.
Contributor
|
looks legit. LGTM |
abarth
added a commit
that referenced
this pull request
Aug 17, 2015
Rename Widget.root to Widget.renderObject
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.36 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@a669cc5...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
rootis confusing because this value isn't the root of anything.It's just the associated
RenderObjectinstance.