This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Realize kernel asset mappings on a worker thread if one is available. #6648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This updates the asset manager to use shared pointer instead of ref pointer. In a subsequent patch, I want to make it so that that engine shutdown before the call is serviced does not unnecessarily process the tasks. That will require the use of a weak pointer and the fml::WeakPtrs wont be safe for that use case. |
Contributor
Author
|
Parallelizes the asset loads with the isolate initialization. Earlier this was serial and took close to 600ms on certain workloads before the isolate initialization could start.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2018
flutter/engine@2586e94...6c2477b git log 2586e94..6c2477b --no-merges --oneline 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2018
flutter/engine@2586e94...9f2e2ba git log 2586e94..9f2e2ba --no-merges --oneline 9f2e2ba Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644) 9669b70 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569) 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2018
flutter/engine@2586e94...914551b git log 2586e94..914551b --no-merges --oneline 914551b Dart SDK roll for 2018-10-24 9f2e2ba Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644) 9669b70 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569) 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 25, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2018
flutter/engine@2586e94...ff0525f git log 2586e94..ff0525f --no-merges --oneline ff0525f Add missing entry-points. (flutter/engine#6634) 08771fe Revert dart before engine commit 26e8840 (flutter/engine#6656) 914551b Dart SDK roll for 2018-10-24 9f2e2ba Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644) 9669b70 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569) 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2018
flutter/engine@2586e94...a6e816b git log 2586e94..a6e816b --no-merges --oneline a6e816b Roll src/third_party/skia 4f598e8c829a..dfca8f6adb6b (7 commits) (flutter/engine#6658) ff0525f Add missing entry-points. (flutter/engine#6634) 08771fe Revert dart before engine commit 26e8840 (flutter/engine#6656) 914551b Dart SDK roll for 2018-10-24 9f2e2ba Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644) 9669b70 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569) 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 25, 2018
flutter/engine@2586e94...a6e816b git log 2586e94..a6e816b --no-merges --oneline a6e816b Roll src/third_party/skia 4f598e8c829a..dfca8f6adb6b (7 commits) (flutter/engine#6658) ff0525f Add missing entry-points. (flutter/engine#6634) 08771fe Revert dart before engine commit 26e8840 (flutter/engine#6656) 914551b Dart SDK roll for 2018-10-24 9f2e2ba Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644) 9669b70 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569) 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
flutter/engine@2586e94...a6e816b git log 2586e94..a6e816b --no-merges --oneline a6e816b Roll src/third_party/skia 4f598e8c829a..dfca8f6adb6b (7 commits) (flutter/engine#6658) ff0525f Add missing entry-points. (flutter/engine#6634) 08771fe Revert dart before engine commit 26e8840 (flutter/engine#6656) 914551b Dart SDK roll for 2018-10-24 9f2e2ba Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644) 9669b70 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569) 6c2477b fix setter for viewOpaque (flutter/engine#6653) 2bd8c94 Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654) e1e6093 Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648) d3874a9 Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652) 3dddf4d Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650) 7b3bb62 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647) 26e8840 Dart SDK roll for 2018-10-23 9829c51 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#21399