Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll back _countryCode assert - breaking change #6693

Merged
GaryQian merged 2 commits into from
Oct 30, 2018
Merged

Roll back _countryCode assert - breaking change #6693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee98f3
Roll back _countryCode assert - breaking change
GaryQian Oct 30, 2018
3af991e
Add tests back in
GaryQian Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/ui/window.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@ class Locale {
this._countryCode,
]) : assert(_languageCode != null),
assert(_languageCode != ''),
scriptCode = null,
assert(_countryCode != '');
scriptCode = null;

/// Creates a new Locale object.
///
Expand Down
2 changes: 2 additions & 0 deletions testing/dart/locale_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ void main() {
expect(const Locale('en').toString(), 'en');
expect(const Locale('en'), new Locale('en', $null));
expect(const Locale('en').hashCode, new Locale('en', $null).hashCode);
expect(const Locale('en'), isNot(new Locale('en', '')));
expect(const Locale('en').hashCode, isNot(new Locale('en', '').hashCode));
expect(const Locale('en', 'US').toString(), 'en_US');
expect(const Locale('iw').toString(), 'he');
expect(const Locale('iw', 'DD').toString(), 'he_DE');
Expand Down