This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add onStart hook to FlutterFragmentActivity #6719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like this file was missed when onStart hooks were added recently in this pull request: #5177
Contributor
Author
|
This request is related to flutter/flutter#2716 (comment) |
Contributor
Author
|
@HansMuller friendly ping |
matthew-carroll
approved these changes
Nov 9, 2018
Contributor
|
@jason-simmons can you also give a sanity check? I don't see why onStart() shouldn't be added, or why it may have been excluded. Any counterpoints on your end? |
Contributor
|
I think I just missed it |
Contributor
|
@jason-simmons @jonahwilliams are you both good with me merging this? |
Contributor
|
LGTM |
Contributor
|
@matthew-carroll Any status on this PR? |
Contributor
|
Hi @GaryQian I just saw your comment here, as well as on chat. Previously I was waiting for Jason's approval. I'm OK merging without that, but for right now the source tree is frozen. I don't think we're merging anything other than critical bug fixes and I don't think this rises to that level. @Hixie please let me know if you feel differently about whether or not this is merge-able during the freeze. |
jason-simmons
approved these changes
Nov 29, 2018
Member
|
@dguralnick @matthew-carroll @jason-simmons Is this still relevant? Can this be merged? |
Contributor
|
I'll go ahead and merge this |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
bkonyi
added a commit
to flutter/flutter
that referenced
this pull request
Jan 8, 2019
flutter/engine@7112b72...e5ec3cf git log 7112b72..e5ec3cf --no-merges --oneline e5ec3cf Dart SDK roll for 2019-01-08 08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10 commits) (flutter/engine#7407) e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12 commits) (flutter/engine#7406) 0f8273b Dart SDK roll for 2019-01-07 4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401) 4820cbe Dart SDK roll for 2019-01-07 8eccb86 Add onStart hook to FlutterFragmentActivity (flutter/engine#6719) f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10 commits) (flutter/engine#7400) 5ca8aad Announce in/out of list (flutter/engine#6918) 4487d39 Replace Java code with equivalent, more concise code. (flutter/engine#7398) 395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11 commits) (flutter/engine#7394) 5965f90 Make `ParagraphConstraints` have const constructor (flutter/engine#7346) e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2 commits) (flutter/engine#7390) f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2 commits) (flutter/engine#7389)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2019
bkonyi
added a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2019
flutter/engine@7112b72...e5ec3cf git log 7112b72..e5ec3cf --no-merges --oneline e5ec3cf Dart SDK roll for 2019-01-08 08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10 commits) (flutter/engine#7407) e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12 commits) (flutter/engine#7406) 0f8273b Dart SDK roll for 2019-01-07 4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401) 4820cbe Dart SDK roll for 2019-01-07 8eccb86 Add onStart hook to FlutterFragmentActivity (flutter/engine#6719) f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10 commits) (flutter/engine#7400) 5ca8aad Announce in/out of list (flutter/engine#6918) 4487d39 Replace Java code with equivalent, more concise code. (flutter/engine#7398) 395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11 commits) (flutter/engine#7394) 5965f90 Make `ParagraphConstraints` have const constructor (flutter/engine#7346) e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2 commits) (flutter/engine#7390) f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2 commits) (flutter/engine#7389)
gamebox
pushed a commit
to gamebox/flutter
that referenced
this pull request
Jan 28, 2019
flutter/engine@7112b72...e5ec3cf git log 7112b72..e5ec3cf --no-merges --oneline e5ec3cf Dart SDK roll for 2019-01-08 08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10 commits) (flutter/engine#7407) e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12 commits) (flutter/engine#7406) 0f8273b Dart SDK roll for 2019-01-07 4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401) 4820cbe Dart SDK roll for 2019-01-07 8eccb86 Add onStart hook to FlutterFragmentActivity (flutter/engine#6719) f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10 commits) (flutter/engine#7400) 5ca8aad Announce in/out of list (flutter/engine#6918) 4487d39 Replace Java code with equivalent, more concise code. (flutter/engine#7398) 395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11 commits) (flutter/engine#7394) 5965f90 Make `ParagraphConstraints` have const constructor (flutter/engine#7346) e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2 commits) (flutter/engine#7390) f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2 commits) (flutter/engine#7389)
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@7112b72...e5ec3cf git log 7112b72..e5ec3cf --no-merges --oneline e5ec3cf Dart SDK roll for 2019-01-08 08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10 commits) (flutter/engine#7407) e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12 commits) (flutter/engine#7406) 0f8273b Dart SDK roll for 2019-01-07 4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401) 4820cbe Dart SDK roll for 2019-01-07 8eccb86 Add onStart hook to FlutterFragmentActivity (flutter/engine#6719) f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10 commits) (flutter/engine#7400) 5ca8aad Announce in/out of list (flutter/engine#6918) 4487d39 Replace Java code with equivalent, more concise code. (flutter/engine#7398) 395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11 commits) (flutter/engine#7394) 5965f90 Make `ParagraphConstraints` have const constructor (flutter/engine#7346) e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2 commits) (flutter/engine#7390) f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2 commits) (flutter/engine#7389)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this file was missed when onStart hooks were added recently in this pull request: #5177