This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't load a splash screen by default #6883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesderlin
approved these changes
Nov 16, 2018
Contributor
jamesderlin
left a comment
jamesderlin
left a comment
There was a problem hiding this comment.
The code looks fine to me. Switching to an opt-in system probably should be considered a breaking change, so be sure to announce it appropriately.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2018
flutter/engine@5a694c4...c02dd8f git log 5a694c4..c02dd8f --no-merges --oneline c02dd8f Don't load a splash screen by default (flutter/engine#6883) 8a42213 Remove unused examples targets. (flutter/engine#6882) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#24420
This allows a consumer to decide whether they want to load the default storyboard/splash screen, and opt in by default. They could still get the previous behavior by calling [flutterViewController loadDefaultSplashScreen], but won't be forced into it in scenarios where they probably don't want it (as with a prewarmed engine for a child view/viewcontroller).