This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[HR] Documentation cleanup #7370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
force-pushed
the
docs
branch
2 times, most recently
from
7dc8e5e to
84c349f
Compare
amirh
reviewed
Jan 7, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
RSLGTM for isolate_name_server (I don't know it at all, just assuming what you wrote is correct 😄 ).
LGTM for the rest.
|
|
||
| /// A handle to an image codec. | ||
| /// | ||
| /// This class is created by the engine, and should not be instantiated |
Contributor
There was a problem hiding this comment.
nit: maybe worth making this a macro
Contributor
Author
There was a problem hiding this comment.
I'll leave that for the next person who wants to do some cleanup :-)
bkonyi
approved these changes
Jan 7, 2019
lib/ui/isolate_name_server.dart
Outdated
| abstract class IsolateNameServer { | ||
| /// Looks up the [SendPort] associated with a given name. Returns null | ||
| /// if the name does not exist. | ||
| /// Static methods to allow for simple sharing of [SendPort]s across [Isolates]. |
Contributor
There was a problem hiding this comment.
Should be [Isolate]s for consistency.
Contributor
Author
There was a problem hiding this comment.
oops. good catch. fixed.
| @override | ||
| int get hashCode => _handle; | ||
| bool operator ==(dynamic other) { | ||
| if (runtimeType != other.runtimeType) |
Contributor
There was a problem hiding this comment.
Any particular reason for this change here? Does this not accomplish the same thing?
Contributor
Author
There was a problem hiding this comment.
The original code used is, which isn't correct in operator == (because it makes different subclasses compare equal).
We have a boilerplate pattern we use for all operator == throughout Flutter.
Contributor
|
Can you land this? |
Contributor
Author
|
Updated per comments. This can land on green (feel free to land it for me if you see it's green). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
This was referenced Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
This was referenced Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.