-
Notifications
You must be signed in to change notification settings - Fork 6k
add ColorFilter matrix support #7459
Conversation
|
Thank you for doing this! I've been thinking about this as well, it would help the process along for implementing filter effects for flutter_svg. I think the approach overall makes sense, just a few small things on it. |
|
I'll make the required changes. My idea of how we can improve this is to pass a list of |
* remake `_listEquals` private
|
Great! @jason-simmons would you mind taking a look at this and seeing if I missed anything? |
|
Oh, and combining them is something we can probably handle at the framework level right? It's just vector math stuff? |
|
Yes. And also we could remove or deprecate |
|
https://gist.github.com/long1eu/5187b17f039fa3dae484640448771009 port from android |
jason-simmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I would probably lean towards creating a package out of that, or creating something in the framework for it rather than increasing the engine API surface. |
|
@dnfield of course |
This will solve
flutter/flutter#6688 and flutter/flutter#19468