This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Keep engine alive if VC is not deallocated #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 22, 2019
Contributor
Author
|
@kangwang1988 I'm going to land this to fix the TODAY issue. I'd really like your'e feedback though and would be happy to rearrange this if you think I'm missing any cases. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2019
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2019
* 88fee08 Remove the shell build target's dependency on the embedder library (flutter/engine#7549) * 2123d3a Keep engine alive if VC is not deallocated (flutter/engine#7544) * c57e66f fixes android pressure range (flutter/engine#7516) * 319e1c5 Roll src/third_party/skia 347d36586cb6..325778b8884b (7 commits) (flutter/engine#7552)
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
* 88fee08 Remove the shell build target's dependency on the embedder library (flutter/engine#7549) * 2123d3a Keep engine alive if VC is not deallocated (flutter/engine#7544) * c57e66f fixes android pressure range (flutter/engine#7516) * 319e1c5 Roll src/third_party/skia 347d36586cb6..325778b8884b (7 commits) (flutter/engine#7552)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7531
Fixes flutter/flutter#26660
Fixes flutter/flutter#26848
The FlutterViewController can end up having a child view controller that makes it
viewDidDisappear, but we don't want to get rid of the engine in that case. We could try to track some state around that in FlutterViewController and override the presenting methods, but that seems overly complicated and likely to miss some scenario.A solution similar to this was considered as part of #6879 but rejected at the time as feeling cumbersome. The workflow where a FlutterViewController disappears but still needs to maintain an engine (even though it's not a "fully" headless engine) wasn't considered at the time.