This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Provide access to GLFW window in plugins #8806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins may need to be able to access functions affecting the GLFW window (e.g., a plugin to resize the window). This restructures the API to create a distinction at both the C and C++ level between the window controller, which provides access to high-level behaviors driving the Flutter application, and the window, which provides access to functions to affect the UI state of the window (i.e., wrapped GLFWwindow functions). Also provides a PluginRegistrar extension for plugins that need access to GLFW-specific functionality.
Member
|
/cc @amirh @iskakaushik FYI |
chinmaygarde
reviewed
May 6, 2019
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Nits around memory management of the C++ wrappers.
chinmaygarde
approved these changes
May 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2019
aam
added a commit
to aam/flutter
that referenced
this pull request
May 7, 2019
``` git log 0e500da..5a045dd --no-merges --oneline 5a045dd Log instead of throwing (flutter/engine#8881) 7e05f94 Roll src/third_party/skia b0d8b76c4f62..9f0eeac8204f (4 commits) (flutter/engine#8879) e7b9442 Roll src/third_party/skia d05c5eec42e9..b0d8b76c4f62 (1 commits) (flutter/engine#8877) b226f25 Roll src/third_party/skia d699a66fa220..d05c5eec42e9 (2 commits) (flutter/engine#8876) 4be57cf Roll src/third_party/skia 5f2807b71e71..d699a66fa220 (1 commits) (flutter/engine#8875) bd32875 Roll src/third_party/dart 821c75c584..3173e594ba (9 commits) 53309f8 Roll src/third_party/dart 36c315eacc..821c75c584 (2 commits) bde63eb Roll buildroot to pull in Fuchsia SDK flag updates. (flutter/engine#8870) f6e6d39 Wire up Fuchsia SDK related updated for shell dependencies. flutter#8869 444925f Roll src/third_party/dart cdabea8fe2..36c315eacc (17 commits) 3f9de1a Roll src/third_party/skia 77af4ecd3546..5f2807b71e71 (3 commits) (flutter/engine#8866) 10cbdd4 Add resize functions to GLFW shell (flutter/engine#8864) 62ab9c7 Provide access to GLFW window in plugins (flutter/engine#8806) 4d830d2 Roll src/third_party/skia 7d2ad0fdef01..77af4ecd3546 (9 commits) (flutter/engine#8862) 3671182 Get prebuilt Dart via CIPD (flutter/engine#8859) 07bb4f9 Roll src/third_party/dart 125c5cbf4a..cdabea8fe2 (4 commits) 7bcb665 Roll src/third_party/dart 67df3ff878..125c5cbf4a (6 commits) (flutter/engine#8856) 94b4054 Roll src/third_party/skia 2f3637bf2ed4..7d2ad0fdef01 (1 commits) (flutter/engine#8857) 2c2f060 Roll src/third_party/skia 719a69ca5a6d..2f3637bf2ed4 (2 commits) (flutter/engine#8855) ```
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 7, 2019
flutter/engine@0e500da...df79d63 git log 0e500da..df79d63 --no-merges --oneline df79d63 Roll src/third_party/skia 9f0eeac8204f..056944747072 (4 commits) (flutter/engine#8882) 5a045dd Log instead of throwing (flutter/engine#8881) 7e05f94 Roll src/third_party/skia b0d8b76c4f62..9f0eeac8204f (4 commits) (flutter/engine#8879) e7b9442 Roll src/third_party/skia d05c5eec42e9..b0d8b76c4f62 (1 commits) (flutter/engine#8877) b226f25 Roll src/third_party/skia d699a66fa220..d05c5eec42e9 (2 commits) (flutter/engine#8876) 4be57cf Roll src/third_party/skia 5f2807b71e71..d699a66fa220 (1 commits) (flutter/engine#8875) bd32875 Roll src/third_party/dart 821c75c584..3173e594ba (9 commits) 53309f8 Roll src/third_party/dart 36c315eacc..821c75c584 (2 commits) bde63eb Roll buildroot to pull in Fuchsia SDK flag updates. (flutter/engine#8870) f6e6d39 Wire up Fuchsia SDK related updated for shell dependencies. #8869 444925f Roll src/third_party/dart cdabea8fe2..36c315eacc (17 commits) 3f9de1a Roll src/third_party/skia 77af4ecd3546..5f2807b71e71 (3 commits) (flutter/engine#8866) 10cbdd4 Add resize functions to GLFW shell (flutter/engine#8864) 62ab9c7 Provide access to GLFW window in plugins (flutter/engine#8806) 4d830d2 Roll src/third_party/skia 7d2ad0fdef01..77af4ecd3546 (9 commits) (flutter/engine#8862) 3671182 Get prebuilt Dart via CIPD (flutter/engine#8859) 07bb4f9 Roll src/third_party/dart 125c5cbf4a..cdabea8fe2 (4 commits) 7bcb665 Roll src/third_party/dart 67df3ff878..125c5cbf4a (6 commits) (flutter/engine#8856) 94b4054 Roll src/third_party/skia 2f3637bf2ed4..7d2ad0fdef01 (1 commits) (flutter/engine#8857) 2c2f060 Roll src/third_party/skia 719a69ca5a6d..2f3637bf2ed4 (2 commits) (flutter/engine#8855) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Plugins may need to be able to access functions affecting the GLFW window (e.g., a plugin to resize the window). This restructures the API to create a distinction at both the C and C++ level between the window controller, which provides access to high-level behaviors driving the Flutter application, and the window, which provides access to functions to affect the UI state of the window (i.e., wrapped GLFWwindow functions). Also provides a PluginRegistrar extension for plugins that need access to GLFW-specific functionality.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins may need to be able to access functions affecting the GLFW
window (e.g., a plugin to resize the window). This restructures the API
to create a distinction at both the C and C++ level between the window
controller, which provides access to high-level behaviors driving the
Flutter application, and the window, which provides access to functions
to affect the UI state of the window (i.e., wrapped GLFWwindow
functions).
Also provides a PluginRegistrar extension for plugins that need access
to GLFW-specific functionality.