This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove asserts and add BuildConfig #8821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Meant to open this as a draft - oh well. I will be rebasing this against #8820 once it lands. |
Merged
Contributor
Author
|
This is ready for review. |
mklim
approved these changes
May 2, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM. Someone with more familiarity with the build scripts should also verify the .GN changes though.
shell/platform/android/io/flutter/plugin/common/StandardMessageCodec.java
Outdated
Show resolved
Hide resolved
Merged
chinmaygarde
approved these changes
May 3, 2019
shell/platform/android/BUILD.gn
Outdated
| ] | ||
|
|
||
| build_config = [] | ||
| assert(build_config == [] || true) |
Contributor
There was a problem hiding this comment.
I dont think you meant to leave this in here.
Contributor
Author
|
@mehmetf this is going to need something for the google3 build. Maybe we can talk tomorrow about how to make sure this works |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 3, 2019
flutter/engine@39a950e...4808446 git log 39a950e..4808446 --no-merges --oneline 4808446 Remove asserts and add BuildConfig (flutter/engine#8821) c97bd45 Download the Fuchsia SDK and toolchain in a gclient hook. (flutter/engine#8794) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
This was referenced May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be landed until #8820 (it contains the same changes).
This removes any
assertfrom Java code and guards an AssertionError instead withBuildConfig.DEBUG.Also adds logic to GN to generate the BuildConfig class.
Fixes flutter/flutter#31928
Addresses part of flutter/flutter#28848