This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Wire intent args for observatory port #9378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-carroll
approved these changes
Jun 19, 2019
| public static final String ARG_KEY_VERBOSE_LOGGING = "verbose-logging"; | ||
| public static final String ARG_VERBOSE_LOGGING = "--verbose-logging"; | ||
| public static final String ARG_KEY_OBSERVATORY_PORT = "observatory-port"; | ||
| public static final String ARG_OBSERVATORY_PORT = "--observatory-port="; |
Contributor
There was a problem hiding this comment.
Should this "=" be here?
Contributor
Author
There was a problem hiding this comment.
It either has to be here or in the concatenation below. I don't have a strong preference - this is the only arg like this right now in here.
chinmaygarde
approved these changes
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 20, 2019
…34745) flutter/engine@54f88ab...7c4f6a6 git log 54f88ab..7c4f6a6 --no-merges --oneline 7c4f6a6 Wire intent args for observatory port (flutter/engine#9378) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
…lutter#34745) flutter/engine@54f88ab...7c4f6a6 git log 54f88ab..7c4f6a6 --no-merges --oneline 7c4f6a6 Wire intent args for observatory port (flutter/engine#9378) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
nitrohsu
added a commit
to nitrohsu/engine
that referenced
this pull request
Feb 21, 2021
`disable-service-auth-codes` set repeatedly. line 289 vs 326 when flutter#9378
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses engine part of flutter/flutter#34731
This will allow people (particularly add-to-app) to specify the observatory port as arguments to the app.