This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't hang to a platform view's input connection after it's disposed #9423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jun 24, 2019
amirh
force-pushed
the
clear_input_target_on_dispose
branch
from
d1d581d to
8f34cb4
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2019
flutter/engine@b188479...b7dd1cd git log b188479..b7dd1cd --no-merges --oneline b7dd1cd ios-unit-tests: Fixed ocmock system header search paths. (flutter/engine#9469) a6e5b10 Forgot a usage of a variable in our script. (flutter/engine#9467) 183a76b Added shebangs to ios unit test scripts. (flutter/engine#9464) 5695445 Don't hang to a platform view's input connection after it's disposed (flutter/engine#9423) 45ef6c8 Remove unused/unimplemented shell constructor (flutter/engine#9459) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@b188479...b7dd1cd git log b188479..b7dd1cd --no-merges --oneline b7dd1cd ios-unit-tests: Fixed ocmock system header search paths. (flutter/engine#9469) a6e5b10 Forgot a usage of a variable in our script. (flutter/engine#9467) 183a76b Added shebangs to ios unit test scripts. (flutter/engine#9464) 5695445 Don&flutter#39;t hang to a platform view&flutter#39;s input connection after it&flutter#39;s disposed (flutter/engine#9423) 45ef6c8 Remove unused/unimplemented shell constructor (flutter/engine#9459) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the crash reported in flutter/flutter#19718 (comment)