This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactoring: make the ExternalViewEmbedder the owner of EmbeddedViewParams #9494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Jul 1, 2019
| ExternalViewEmbedder() = default; | ||
|
|
||
| // the params object used to composite the platform views. | ||
| EmbeddedViewParams embedded_view_params; |
Contributor
There was a problem hiding this comment.
The ExternalViewEmbedder is the objects that's responsible for embedding all platform views, it's a little strange to have it keep the parameters of a specific view here.
Discussed offline: we probably want to std:move the params in platform_view_layer.cc
Contributor
Author
|
Closing this PR as we want to do it another way. New PR is created here #9640 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we copy the mutator stack everywhere.
This PR let the
ExternalViewEmbedderowns theEmbeddedViewParamswhich contains the stack. Since the PaintContext holds a pointer to the ExternalViewEmbedder, we won't copy the stack at unnecessary places again.