-
Notifications
You must be signed in to change notification settings - Fork 6k
Alf stable v1.5.4 xy #9702
Alf stable v1.5.4 xy #9702
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Thanks! Can you make a different PR for each commit/bug/feature? Since each entire PR needs to be reviewed/merged, it makes it easier for the review process. |
| #if TARGET_IPHONE_SIMULATOR | ||
| return [CALayer class]; | ||
| #else // TARGET_IPHONE_SIMULATOR | ||
| // #if TARGET_IPHONE_SIMULATOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't check-in commented code. If there are annotations needed to explain the context of code, please add some text comments.
|
|
||
| - (void)disableGPUOperation { | ||
| [[_engine.get() lifecycleChannel] sendMessage:@"AppLifecycleState.paused"]; | ||
| //暂时通过延时来等待GL操作结束(否则进入后台后的GL操作会闪退) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you guys change these comments to english? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure,we will change it later
|
@xster @christyuj it looks like the this PR is for the purpose of discussion around a couple of changes to the engine. Since I assume the eventual plan is to break out a few orthogonal patches, I'd propose creating a fork and discussing those patches there, or opening a doc/email thread. @xster who on the team should be involved in reviewing this? @christyuj do you plan to make the changes suggested by @xster (e.g. translate comments to English), which would help reviewers? |
|
They're practical and useful fixes but I think the next step is to break this PR down to smaller per feature/issue PRs. @cbracken, these follow up PRs should likely be reviewed by the engine team. |
Hi, everyone. I am a member of alibaba xianyu team. At the invitation of xster, I would like to present some patches that have been repaired by the team for reference.
For the current online 1.5.4 version engine, we have sorted out some internal patches. I know these codes are not a perfect solution, but I hope to share them and explain some specific problems and demands in some scenarios.
Here are some stability and some extended capabilities of texture. As xianyu has 300 million users at present, we have some requirements on online stability and performance
I focus on the reasons for the two commit and the ideas for the modifications, which I hope will help the stability of the engine in the future.
Some of the other such as commit aa40f57 has been handled by my colleague kangwang1988 illustrated in #6145, I will not repeat.
Commit 3755a5d
Problem description: Flutter will crash when rendered in the background
Problem analysis: the Flutter Engine instance corresponds to four taskrunners :Platform, UI, GPU and IO. GPU and IO are involved in GPU operation. The current Message Loop cannot guarantee that there is no GPU/IO operation when the App goes back to the background.
Solutions:
Commit dfe3d98
Problem description: xianyu hopes to reuse Native image library and video library in the App. After it is implemented directly through the Flutter Texture mechanism, it is found that the memory is large and the whole rendering process is long, which cannot meet the online requirements.
Problem analysis:

The specific scheme is shown in the figure below
Solutions:
If you want to implement the scenario in the figure above, you need to expose some of the specified interfaces on the engine side.