-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add documentation for platform_view example.
#111623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for platform_view example.
#111623
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Dear auto-submit bot, Please read my PR and see that it only affects comments. Thanks! |
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo comments!
examples/platform_view/macos/Runner/PlatformViewController.swift
Outdated
Show resolved
Hide resolved
ec25002 to
6459db3
Compare
When
platform_viewfirst landed formacOSthere was no documentation for any of the classes added. This PR adds documentation for theMainFlutterWindowand thePlatformViewControllerclasses.fixes #111142
Pre-launch Checklist
///).