Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@e80266b...f9f7706

2023-03-14 flar@google.com Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40243)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #122628 at sha 921cca6

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 14, 2023
@gaaclarke
Copy link
Member

Jim is reverting this so stopping this roll to catch his revert.

@gaaclarke gaaclarke closed this Mar 14, 2023
@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-28590dd6-2ffd-4f19-8afb-824970c1547f-1678822548 branch March 21, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants