Skip to content

remove Mac_ios ios_app_with_extensions_test #131806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 3, 2023
Merged

remove Mac_ios ios_app_with_extensions_test #131806

auto-submit merged 1 commit into from
Aug 3, 2023

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 2, 2023 •
edited
Loading

Removing the extension test that unnecessarily running with devices.

The new hostonly tests were added in #131441

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from keyonghan August 2, 2023 19:35
keyonghan
keyonghan approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz force-pushed the remove_old_extension_test branch from d0274ec to a404488 Compare August 2, 2023 21:26
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 2, 2023

auto label is removed for flutter/flutter, pr: 131806, due to - The status or check suite Linux web_canvaskit_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 2, 2023

Not sure why Linux firebase_android_embedding_v2_smoke_test is failing, it does not seem related. I will trigger a re-run

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2023
@auto-submit auto-submit bot merged commit 13ff16c into flutter:master Aug 3, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2023
@engine-flutter-autoroll
13ff16c remove Mac_ios ios_app_with_extensions_test (flutter/flutter#…
d6b5220 
…131806)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2023
@engine-flutter-autoroll
13ff16c remove Mac_ios ios_app_with_extensions_test (flutter/flutter#…
ba46934 
…131806)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 4, 2023
@engine-flutter-autoroll
Roll Flutter from c00d241 to 2ba9f7b (25 revisions) (#4646)
11bb9ec 
flutter/flutter@c00d241...2ba9f7b

2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from d15a02a8191c to badca1f7f8c9 (1 revision) (flutter/flutter#131928)
2023-08-04 polinach@google.com Upgrade packages. (flutter/flutter#131927)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0725a6f519d0 to d15a02a8191c (2 revisions) (flutter/flutter#131924)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c912e3417e68 to 0725a6f519d0 (2 revisions) (flutter/flutter#131917)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03137a3b9b81 to c912e3417e68 (2 revisions) (flutter/flutter#131913)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from de0ec1c971ab to 03137a3b9b81 (1 revision) (flutter/flutter#131912)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from e3f75650ac5f to de0ec1c971ab (2 revisions) (flutter/flutter#131910)
2023-08-04 andrewrkolos@gmail.com make `--dart-define` override redundant values in `--dart-define-from-file` (flutter/flutter#131088)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca8d852eddfc to e3f75650ac5f (1 revision) (flutter/flutter#131907)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 098ec489585e to ca8d852eddfc (2 revisions) (flutter/flutter#131905)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4c62dd81d136 to 098ec489585e (2 revisions) (flutter/flutter#131903)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c1de9b8afba to 4c62dd81d136 (4 revisions) (flutter/flutter#131902)
2023-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from b08e1410a06a to 0c1de9b8afba (9 revisions) (flutter/flutter#131897)
2023-08-03 tessertaha@gmail.com Fix TimePicker token issue link (flutter/flutter#131863)
2023-08-03 30870216+gaaclarke@users.noreply.github.com [Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan and opengles (flutter/flutter#131864)
2023-08-03 zanderso@users.noreply.github.com Revert "Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions)" (flutter/flutter#131896)
2023-08-03 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions) (flutter/flutter#131880)
2023-08-03 30870216+gaaclarke@users.noreply.github.com Added new gallery benchmark test that forces opengles. (flutter/flutter#131796)
2023-08-03 engine-flutter-autoroll@skia.org Roll Packages from 4e4961a to d00c1f9 (10 revisions) (flutter/flutter#131866)
2023-08-03 christopherfujino@gmail.com manual pub package roll (flutter/flutter#131804)
2023-08-03 ychris@google.com remove Mac_ios ios_app_with_extensions_test (flutter/flutter#131806)
2023-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46f3e099ad04 to 4cc0b3dab001 (3 revisions) (flutter/flutter#131854)
2023-08-03 47866232+chunhtai@users.noreply.github.com Adds a11y assessment sample app (flutter/flutter#131716)
2023-08-03 60728110+MahmoudZayad@users.noreply.github.com Remove target Staging_build_linux framework_tests_misc (flutter/flutter#126959)
2023-08-03 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 4c1157b9da54 to 46f3e099ad04 (3 revisions) (flutter/flutter#131848)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyanglaz @keyonghan