Try benchmarks on canvaskit/skwasm with skia_enable_optimize_size. #133208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Benchmark metrics look comparable to TOT |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Aug 24, 2023
…size (#45029) This flag removes some code from CanvasKit to reduce size by a little bit. I went ahead and did a run of the benchmarks (flutter/flutter#133208) to see if it negatively affected anything, and there was no difference beyond noise between the current benchmark numbers and the benchmarks with this flag enabled. The size differences are as follows: Before the change: ``` total 30616 drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:33 . drwxr-xr-x 7 jacksongardner primarygroup 224 Aug 10 18:14 .. -rw-r--r--@ 1 jacksongardner primarygroup 6148 May 12 17:41 .DS_Store -rw-r--r-- 2 jacksongardner primarygroup 94899 Aug 23 14:23 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 6631693 Aug 23 14:23 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 2102151 Aug 23 14:23 canvaskit.wasm.br drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:33 chromium -rw-r--r-- 2 jacksongardner primarygroup 161478 Aug 23 14:28 skwasm.js -rwxr-xr-x 2 jacksongardner primarygroup 3296038 Aug 23 14:28 skwasm.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1101502 Aug 23 14:28 skwasm.wasm.br -rw-r--r-- 2 jacksongardner primarygroup 3095 Aug 23 14:28 skwasm.worker.js ./chromium: total 15520 drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:33 . drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:33 .. -rw-r--r-- 2 jacksongardner primarygroup 94545 Aug 23 14:25 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 5223378 Aug 23 14:25 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1492433 Aug 23 14:25 canvaskit.wasm.br ``` After the change: ``` total 28568 drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:42 . drwxr-xr-x 7 jacksongardner primarygroup 224 Aug 10 18:14 .. -rw-r--r--@ 1 jacksongardner primarygroup 6148 May 12 17:41 .DS_Store -rw-r--r-- 2 jacksongardner primarygroup 94899 Aug 23 14:37 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 6401703 Aug 23 14:37 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 2038390 Aug 23 14:37 canvaskit.wasm.br drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:42 chromium -rw-r--r-- 2 jacksongardner primarygroup 161478 Aug 23 14:41 skwasm.js -rwxr-xr-x 2 jacksongardner primarygroup 3143431 Aug 23 14:41 skwasm.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1050854 Aug 23 14:41 skwasm.wasm.br -rw-r--r-- 2 jacksongardner primarygroup 3095 Aug 23 14:41 skwasm.worker.js ./chromium: total 15392 drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:42 . drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:42 .. -rw-r--r-- 2 jacksongardner primarygroup 94545 Aug 23 14:39 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 4993586 Aug 23 14:39 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1427979 Aug 23 14:39 canvaskit.wasm.br ``` The brotli-compressed wasm modules save about 50-70kb each with this flag.
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…size (flutter#45029) This flag removes some code from CanvasKit to reduce size by a little bit. I went ahead and did a run of the benchmarks (flutter/flutter#133208) to see if it negatively affected anything, and there was no difference beyond noise between the current benchmark numbers and the benchmarks with this flag enabled. The size differences are as follows: Before the change: ``` total 30616 drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:33 . drwxr-xr-x 7 jacksongardner primarygroup 224 Aug 10 18:14 .. -rw-r--r--@ 1 jacksongardner primarygroup 6148 May 12 17:41 .DS_Store -rw-r--r-- 2 jacksongardner primarygroup 94899 Aug 23 14:23 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 6631693 Aug 23 14:23 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 2102151 Aug 23 14:23 canvaskit.wasm.br drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:33 chromium -rw-r--r-- 2 jacksongardner primarygroup 161478 Aug 23 14:28 skwasm.js -rwxr-xr-x 2 jacksongardner primarygroup 3296038 Aug 23 14:28 skwasm.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1101502 Aug 23 14:28 skwasm.wasm.br -rw-r--r-- 2 jacksongardner primarygroup 3095 Aug 23 14:28 skwasm.worker.js ./chromium: total 15520 drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:33 . drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:33 .. -rw-r--r-- 2 jacksongardner primarygroup 94545 Aug 23 14:25 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 5223378 Aug 23 14:25 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1492433 Aug 23 14:25 canvaskit.wasm.br ``` After the change: ``` total 28568 drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:42 . drwxr-xr-x 7 jacksongardner primarygroup 224 Aug 10 18:14 .. -rw-r--r--@ 1 jacksongardner primarygroup 6148 May 12 17:41 .DS_Store -rw-r--r-- 2 jacksongardner primarygroup 94899 Aug 23 14:37 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 6401703 Aug 23 14:37 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 2038390 Aug 23 14:37 canvaskit.wasm.br drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:42 chromium -rw-r--r-- 2 jacksongardner primarygroup 161478 Aug 23 14:41 skwasm.js -rwxr-xr-x 2 jacksongardner primarygroup 3143431 Aug 23 14:41 skwasm.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1050854 Aug 23 14:41 skwasm.wasm.br -rw-r--r-- 2 jacksongardner primarygroup 3095 Aug 23 14:41 skwasm.worker.js ./chromium: total 15392 drwxr-xr-x 5 jacksongardner primarygroup 160 Aug 23 14:42 . drwxr-xr-x 11 jacksongardner primarygroup 352 Aug 23 14:42 .. -rw-r--r-- 2 jacksongardner primarygroup 94545 Aug 23 14:39 canvaskit.js -rwxr-xr-x 2 jacksongardner primarygroup 4993586 Aug 23 14:39 canvaskit.wasm -rwxr-xr-x 1 jacksongardner primarygroup 1427979 Aug 23 14:39 canvaskit.wasm.br ``` The brotli-compressed wasm modules save about 50-70kb each with this flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.