Remove InkSparkle.constantTurbulenceSeedSplashFactory usage #139481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Piinks
approved these changes
Dec 4, 2023
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Clean up LGTM! Thank you!
bleroux
deleted the
Remove_InkSparkle_constantTurbulenceSeedSplashFactory_usage
branch
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Dec 5, 2023
…r-xu/flutter into fix/gridview_delegate * 'fix/gridview_delegate' of https://github.com/hello-coder-xu/flutter: (162 commits) add gridview children view fix gridview delegate mainAxisExtent Enable TapRegion to detect all mouse button click (flutter#136799) [flutter_tools] build ios-frameworks: option to exclude plugin frameworks from the build (flutter#129739) Roll Flutter Engine from b87c1b3 to eee8aeb (1 revision) (flutter#139495) Add Impeller complex layout impeller benchmarks. (flutter#139490) Roll Flutter Engine from cf12246 to b87c1b3 (3 revisions) (flutter#139491) Remove InkSparkle.constantTurbulenceSeedSplashFactory usage (flutter#139481) Roll Packages from bc72d15 to 5d9874f (9 revisions) (flutter#139480) Roll Flutter Engine from cc9a72b to cf12246 (1 revision) (flutter#139468) Roll Flutter Engine from 69cbf87 to cc9a72b (1 revision) (flutter#139466) Roll Flutter Engine from 05e7f46 to 69cbf87 (1 revision) (flutter#139453) Roll Flutter Engine from e782ab1 to 05e7f46 (1 revision) (flutter#139439) Roll Flutter Engine from 80a2fd7 to e782ab1 (1 revision) (flutter#139437) Roll Flutter Engine from 7ff24be to 80a2fd7 (1 revision) (flutter#139436) Roll Flutter Engine from cfabe42 to 7ff24be (1 revision) (flutter#139433) Roll Flutter Engine from f0122c3 to cfabe42 (1 revision) (flutter#139423) Roll Flutter Engine from f23c33f to f0122c3 (1 revision) (flutter#139422) Roll Flutter Engine from d441f08 to f23c33f (2 revisions) (flutter#139421) Roll Flutter Engine from 27d37db to d441f08 (1 revision) (flutter#139419) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the call to
InkSparkle.constantTurbulenceSeedSplashFactorywhich was introduced in #137998.This is now obsolete since #138757 was merged and InkSparkle randomness is no more active in tests.