Use positive path bounds for display list visibility test. #178667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skia does not have a consistent policy for handling "inverted" shapes (rects, rrects, ovals): some Skia APIs check or flip the bounds, some do not. In general, Skia treats inverted shapes as undefined behavior and doesn't want to commit to an explicit contract for handling them. Further, this undefined behavior is actually soon going to change (to different undefined behavior; parent bug is skbug.com/454646294). One instance where reliance on this undefined Skia behavior impacts flutter is mentioned in flutter/engine#42556. This PR applies the same fix to drawPath(), removing its dependence on undefined Skia behavior.
tdenniston
force-pushed
the
skpath-patch
branch
from
6587cb1 to
eae47e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skia does not have a consistent policy for handling "inverted" shapes (rects, rrects, ovals): some Skia APIs check or flip the bounds, some do not. In general, Skia treats inverted shapes as undefined behavior and doesn't want to commit to an explicit contract for handling them. Further, this undefined behavior is actually soon going to change (to different undefined behavior; parent bug is skbug.com/454646294).
One instance where reliance on this undefined Skia behavior impacts flutter is mentioned in flutter/engine#42556. This PR applies the same fix to drawPath(), removing its dependence on undefined Skia behavior.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.