Skip to content

Revert "Migrate template to Gradle 6.7 and AGP 4.1.0" #71096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amirh merged 1 commit into from
Nov 23, 2020
Merged

Revert "Migrate template to Gradle 6.7 and AGP 4.1.0" #71096

amirh merged 1 commit into from
Nov 23, 2020

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Nov 23, 2020

Reverts #70808

This broke flutter/plugins, see: https://cirrus-ci.com/task/6538283054268416

cc @christopherfujino

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@amirh amirh requested a review from blasten November 23, 2020 18:54
cyanglaz
cyanglaz approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh amirh merged commit 7df04fd into master Nov 23, 2020
@amirh amirh deleted the revert-70808-gradle_6_0 branch November 23, 2020 20:27
@jason-simmons
Copy link
Member

jason-simmons commented Nov 23, 2020

The upgrade to Android Gradle plugin 4.1.0 was also causing failures in local engine builds (see #65399).

I have a fix pending (flutter/engine#22685, plus a flutter_tools change to create symlinks to the Maven metadata)

@jhass
Copy link

jhass commented Nov 23, 2020

Should reopen #58247 / #49438 ?

@mikehardy mikehardy mentioned this pull request Dec 1, 2020
Merged
10 tasks
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blasten blasten Awaiting requested review from blasten

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amirh @jason-simmons @jhass @cyanglaz