Skip to content

[multiple] Format code #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stuartmorgan-g merged 2 commits into from
Aug 15, 2022
Merged

[multiple] Format code #2452

stuartmorgan-g merged 2 commits into from
Aug 15, 2022

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 12, 2022 •
edited
Loading

Apply new format rules to some dart files.

This fixes the flutter -> plugin roll

Flutter roll included: #2448

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 12, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cyanglaz cyanglaz added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 12, 2022
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 12, 2022

No need to update version because all the files are test files

@Hixie
Copy link
Contributor

Hixie commented Aug 12, 2022

test-exempt: formatting. also, is a test.

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Aug 15, 2022

Landing manually; publishabel failure is incorrect due to cirruslabs/cirrus-ci-docs#1054

@stuartmorgan-g stuartmorgan-g merged commit 770d899 into flutter:main Aug 15, 2022
@cyanglaz cyanglaz deleted the format branch August 16, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: flutter_markdown p: metrics_center

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyanglaz @Hixie @stuartmorgan-g